[jit] Make ScriptModule.training an attribute instead of a parameter #19587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Add test? |
Contributor
Author
|
This is just a refactor, it's already covered in |
eellison
reviewed
Apr 22, 2019
Contributor
eellison
left a comment
eellison
left a comment
There was a problem hiding this comment.
Maybe add serialization test? That's that this PR was a response to right
Contributor
Author
|
@pytorchbot retest this please |
driazati
requested review from
apaszke,
ebetica,
goldsborough,
mrshenli,
pietern and
yf225
as code owners
yf225
added
the
triaged
added 3 commits
May 13, 2019 18:29
pytorchbot
added
the
module: pybind
added 3 commits
May 14, 2019 15:16
Member
|
hey what happened to this guy |
driazati
requested review from
eellison
and removed request for
apaszke,
ebetica,
goldsborough,
mrshenli,
pietern and
yf225
Contributor
Author
|
@pytorchbot rebase this please |
suo
approved these changes
May 28, 2019
torch/csrc/jit/script/module.cpp
Outdated
| submod->train(on); | ||
| } | ||
| register_buffer("training", torch::tensor(on ? 1 : 0, at::kLong)); | ||
| for (auto& submod : get_modules()) { |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
driazati
pushed a commit
that referenced
this pull request
May 29, 2019
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 6, 2019
Summary: Redo of #19587 ](https://our.intern.facebook.com/intern/diff/15560540/) Pull Request resolved: #21078 Pulled By: driazati Differential Revision: D15560540 fbshipit-source-id: f415775d87c163f93b3bbdd5f87c9ff73f58b049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Remove the hack we had previously where
trainingwas a bufferDifferential Revision: D15502768