[jit] Add primitive types on weak module as attibutes #19439
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For types that can be made into attributes, copy them over as jit Attributes when creating a `WeakScriptModuleProxy` object
facebook-github-bot
added
the
oncall: jit
added 4 commits
April 18, 2019 15:13
[jit] Copy non-container properties of weak modules For types that can be made into attributes, copy them over as jit Attributes when creating a `WeakScriptModuleProxy` object gh-metadata: pytorch pytorch 19439 gh/driazati/18/head
[jit] Copy non-container properties of weak modules For types that can be made into attributes, copy them over as jit Attributes when creating a `WeakScriptModuleProxy` object gh-metadata: pytorch pytorch 19439 gh/driazati/18/head
driazati
requested review from
apaszke,
ebetica,
ezyang,
fmassa,
goldsborough,
mrshenli,
pietern,
soumith and
yf225
as code owners
driazati
changed the title
Contributor
Author
|
Closing for #21379 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
For types that can be made into attributes, copy them over as jit
Attributes when creating a
WeakScriptModuleProxyobjectFixes #19363