Transformer #19274

zhangguanheng66 · 2019-04-15T20:32:13Z

Create a PR for comments. The model is still WIP but I want to have some feedbacks before moving too far. The transformer model depends on several modules, like MultiheadAttention (landed), PositionalEncoding, FeedForward... If they are available already, I will switch to the existing ones. Otherwise, those modules could be landed by separate PRs.

Transformer is implemented based on the paper (https://papers.nips.cc/paper/7181-attention-is-all-you-need.pdf). Users have the flexibility to build a transformer with self-defined and/or built-in components (i.e encoder, decoder, encoder_layer, decoder_layer). Calling buildTransformerModel() function will generate a generic transformer model. Then, Users could modify sub-layers as needed.

A test case was created to train a simple transformer model (see TestNN.test_transformer_number_match).

zhangguanheng66 · 2019-04-15T20:33:02Z

@cpuhrsch @soumith @myleott. Any feedbacks are appreciated.

cpuhrsch · 2019-04-15T21:16:05Z

torch/nn/modules/transformer.py

I think it's fine if you move this explicitly into the callsites instead of creating another layer, since self.d_model is only a scalar.

cpuhrsch · 2019-04-15T21:18:04Z

torch/nn/modules/transformer.py

This is a very common pattern in general. For now I think it's ok if you do this explicitly instead of using a separate Module within Encoder and DecoderLayer and comment that it could be fused.

cpuhrsch · 2019-04-15T21:21:24Z

Overall I think the temporary layers should be made private or merged into the respective models (and then marked as fuse-able). That'll minimize the number of potential additions to our nn library to only the Transformer components. After we the tests pass and we have more docs we should pull in more people to see if we can get them to use it within their libraries. If this diff becomes rather contentious, we should consider merging it into torchtext first.

cpuhrsch · 2019-04-15T21:23:15Z

cc @soumith

cpuhrsch · 2019-04-15T22:03:21Z

cc @gchanan

cpuhrsch · 2019-05-03T18:51:41Z

test/test_nn.py

Why is this necessary?

it is just a unit test for the transformer module.

can you not use any of the existing test helpers in this file?

cpuhrsch · 2019-05-03T18:52:11Z

test/test_nn.py

What is "d_ff"? The name is a bit nondescript.

Will make some changes in the next commit.

cpuhrsch · 2019-05-03T18:52:32Z

test/test_nn.py

I thought "Variable" was deprecated

I don't see a warning for now.

it's deprecated -- we don't warn on some ubiquitous calls because basically all pytorch code uses them.

yea, just src = torch.randint(1, V, (10, 1)) is sufficient

but again, see my comments above. a full convergence test is no place for our unit test suite, it does not catch implementation bugs.

cpuhrsch · 2019-05-03T18:53:16Z

test/test_nn.py

There's a torch "allclose" equivalent. You can't always assume np is available. If you have to rely on numpy, decorate the test to be skipped if numpy isn't available (see other tests for code examples).

I will search and make some changes.

cpuhrsch · 2019-05-03T18:54:37Z

test/test_nn.py

If these are specific to your test, I'd add them to the local scope of that test, i.e. move them into the function itself. This way you avoid making these available to other tests and clearly specify the scope.

cpuhrsch · 2019-05-03T18:55:46Z

test/test_nn.py

There should be an optimizer that already does this and if not, if this is common, we should add it explicitly. What features do our current optimizers lack, that this one provides?

cpuhrsch · 2019-05-03T18:56:11Z

test/test_nn.py

If this is a common loss for Transformers, we should also add it to our losses.

please remove before finalizing the PR (see my comments above)

cpuhrsch · 2019-05-03T18:56:35Z

test/test_nn.py

Since this is a common name, it's important to be local in scope to the test.

please remove before finalizing the PR (see my comments above)

cpuhrsch · 2019-05-03T18:57:13Z

test/test_nn.py

This types of integration tests are definitely useful. Are there smaller unit tests we could also look at to test for edge cases (empty input etc. etc.)?

cpuhrsch · 2019-05-03T18:59:22Z

test/test_nn.py

I'd move the Embedding outside of the Transformer. That is, the result of data_gen will be passed through an instance of nn.Embedding outside of this forward call. The reasoning for that is, that someone might want to use a different kind of Embedding and will then need to reimplement their own Transformer. We also don't do this for LSTM.

This is crucial for libs like allennlp or pytext.

cpuhrsch · 2019-05-03T19:49:32Z

torch/nn/modules/transformer.py

I'd exclude this from the Transformer.

cpuhrsch · 2019-05-03T19:49:45Z

torch/nn/modules/transformer.py

Same with the positional encoding.

cpuhrsch · 2019-05-03T19:51:43Z

torch/nn/modules/transformer.py

This should be replaceable by a normalization layer.

we have a native LayerNorm as well... https://pytorch.org/docs/stable/nn.html?highlight=layernorm#torch.nn.LayerNorm

cpuhrsch · 2019-05-03T19:53:00Z

torch/nn/modules/transformer.py

I suggest we inline the implementation of FeedForward until we're implementing a fused layer or such.

The reasoning is that FeedForward is quite small and we've historically decided to not introduce an abstraction for this type of model, but rather require the user to implement it herself.

When you inline it, do mark it as such, so that we can possibly pull it back out later on

yea I agree.

cpuhrsch · 2019-05-03T19:54:09Z

torch/nn/modules/transformer.py

I suggest we remove this entirely.

cpuhrsch · 2019-05-03T19:54:43Z

torch/nn/modules/transformer.py

This also is very small and should be inlined.

cpuhrsch · 2019-05-03T19:54:57Z

torch/nn/modules/transformer.py

This should be left to the user.

cpuhrsch · 2019-05-03T19:55:09Z

torch/nn/modules/transformer.py

This should be left to the user. It's something you could define locally for your integration test.

cpuhrsch · 2019-05-03T19:58:23Z

torch/nn/modules/transformer.py

Why is this method necessary?

cpuhrsch · 2019-05-03T20:00:43Z

torch/nn/modules/transformer.py

You can assume that the user is passing the result of something akin to "self.src_embed(self.pos_encoder(src))" directly as the input (src). This is not something I'd add statically. We usually require the user to do the embedding herself and then pass in the result vector to our models.

cpuhrsch · 2019-05-03T20:14:29Z

torch/nn/modules/transformer.py

If you remove the Embedding specialization you can call this input_size

Summary: Pull Request resolved: pytorch#19402 This pass propagate the qparams calculated after calibration to the quant nodes which will be used later for quantization Differential Revision: D14995230 fbshipit-source-id: 5709153ea1c039c4ab4470ddb689a303b0bcc6fd

Summary: Pull Request resolved: pytorch#19680 This was broken for quite some time because of an operator schema check that went into effect at some point in time. Reviewed By: manojkris Differential Revision: D15055082 fbshipit-source-id: 7f730f9b810bdaffd69bab7ac4d02c5b2e40645b

Summary: Pull Request resolved: pytorch#19966 Reviewed By: yinghai Differential Revision: D15096086 fbshipit-source-id: 8e6a26c46898f99d411dd5841f086946884b2457

…ytorch#19910) Summary: Pull Request resolved: pytorch#19910 This change modifies the quant-dequant node pattern from qparam->q->dq to qparam->q->int_repr->qparam->dq. The motivation for this change is to make the qparams required for op substition one level up at dequant node instead of multiple levels up. Differential Revision: D15120146 fbshipit-source-id: 74b0fd5cb50a338f562740a9cc727a7791c718c3

Summary: Pull Request resolved: pytorch#20001 att Reviewed By: zrphercule Differential Revision: D15164116 fbshipit-source-id: dab19fb84fa0ab648103317af5509703db918682

Summary: Pull Request resolved: pytorch#19981 Differential Revision: D15174219 Pulled By: pjh5 fbshipit-source-id: 205952aa90ed93f193f40d4293f5a8d82fa33ed6

Summary: Stack from [ghstack](https://github.com/ezyang/ghstack): * **pytorch#19686 [jit] Remove try/catch in constant propagation** The try-catch here gets tripped pretty often when constant prop is run which screws up `catch throw` in gdb.](https://our.intern.facebook.com/intern/diff/15170134/) Pull Request resolved: pytorch#19686 Pulled By: driazati Differential Revision: D15170134 fbshipit-source-id: 93688561126f3ab582c8358e8f2787f7fce9aa73

Summary: Stack from [ghstack](https://github.com/ezyang/ghstack): * **pytorch#20026 Remove warnings on new_* constructors** Revert of pytorch#16770, fixes pytorch#19995 Pull Request resolved: pytorch#20026 Pulled By: driazati Differential Revision: D15171691 fbshipit-source-id: 057c3b4a9fd6086ca240007e5404a286080f04b6

Summary: Pull Request resolved: pytorch#19999 ghimport-source-id: 81157c6 Differential Revision: D15169025 Pulled By: ljk53 fbshipit-source-id: 8e6f8df6dec6d21d6c7e743e974f4fcfff7cdeb5

Summary: Pull Request resolved: pytorch#19760 ghimport-source-id: d0aabee Differential Revision: D15087655 Pulled By: ljk53 fbshipit-source-id: ac133dfc2301c2a86c41b4b8f1483d7d23824e1e

Summary: Fixes pytorch#19314 Pull Request resolved: pytorch#19380 Differential Revision: D15167858 Pulled By: Krovatkin fbshipit-source-id: e87261bbf3e6f8df0601df80280eb3dba42798cd

…3599ef (pytorch#20012) Summary: Pull Request resolved: pytorch#20012 Previous import was f1311e74ec8a91cbf86094cd6f10157cbf00c536 Included changes: - **[7d7bc83d](onnx/onnx@7d7bc83d)**: fix shape inference (pytorch#1984) <Ashwini Khade> - **[68630bbd](onnx/onnx@68630bbd)**: fixing some of Mod test cases (pytorch#1962) <Jeff Saremi> Reviewed By: zrphercule Differential Revision: D15160934 fbshipit-source-id: c53aff401f56b2febeb6c4ee302670eb12b9b495

Avoid loading modules from torch.nn in transformer.py. clean some lint errors in transformer.py and test_nn.py. A few lint errors. Fix continuation line over-indented.

Change d_ff to dim_feedforward. more help functions to test_transformer_number_match. Remove Embeddings and PositionalEncoder out of transformer.py. Remove LayerNorm and FeedForward in transformer.py. Use the corresponding modules in torch.nn. Remove test_transformer_number_match from test_nn.py. Remove Embeddings and PositionalEncoder out of transformer.py. Update transformer docs. Minor updates in test_nn.py. Fix lint errors.

zhangguanheng66 · 2019-05-06T16:22:02Z

I accidentally rebase and the commit log is too messy. Will create a new PR for merge request.

Summary: Accidentally rebased the old PR and make it too messy. Find it here (#19274) Create a PR for comments. The model is still WIP but I want to have some feedbacks before moving too far. The transformer model depends on several modules, like MultiheadAttention (landed). Transformer is implemented based on the paper (https://papers.nips.cc/paper/7181-attention-is-all-you-need.pdf). Users have the flexibility to build a transformer with self-defined and/or built-in components (i.e encoder, decoder, encoder_layer, decoder_layer). Users could use Transformer class to build a standard transformer model and modify sub-layers as needed. Add a few unit tests for the transformer module, as follow: TestNN.test_Transformer_cell TestNN.test_transformerencoderlayer TestNN.test_transformerdecoderlayer TestNN.test_transformer_args_check TestScript.test_scriptmodule_transformer_cuda There is another demonstration example for applying transformer module on the word language problem. pytorch/examples#555 Pull Request resolved: #20170 Differential Revision: D15417983 Pulled By: zhangguanheng66 fbshipit-source-id: 7ce771a7e27715acd9a23d60bf44917a90d1d572

cpuhrsch reviewed Apr 15, 2019

View reviewed changes

MaksymDel mentioned this pull request May 2, 2019

Remove / move internal transformer implementations allenai/allennlp#2270

Closed

zhangguanheng66 force-pushed the transformer branch 2 times, most recently from 46f965b to cccab3c Compare May 2, 2019 21:34

cpuhrsch reviewed May 3, 2019

View reviewed changes

torch/nn/modules/transformer.py Outdated

Copy link

Contributor

cpuhrsch May 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with the positional encoding.

cpuhrsch reviewed May 3, 2019

View reviewed changes

torch/nn/modules/transformer.py Outdated

Copy link

Contributor

cpuhrsch May 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also is very small and should be inlined.

cpuhrsch reviewed May 3, 2019

View reviewed changes

torch/nn/modules/transformer.py Outdated

Copy link

Contributor

cpuhrsch May 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this method necessary?

cpuhrsch reviewed May 3, 2019

View reviewed changes

torch/nn/modules/transformer.py Outdated

Copy link

Contributor

cpuhrsch May 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove the Embedding specialization you can call this input_size

nishantpdce and others added 14 commits May 6, 2019 09:07

Add the ability to observe intermediate tensors in an onnxifi op

7f98119

Summary: Pull Request resolved: pytorch#19966 Reviewed By: yinghai Differential Revision: D15096086 fbshipit-source-id: 8e6a26c46898f99d411dd5841f086946884b2457

Fix bug in dumpNet (pytorch#20001)

7c3619e

Summary: Pull Request resolved: pytorch#20001 att Reviewed By: zrphercule Differential Revision: D15164116 fbshipit-source-id: dab19fb84fa0ab648103317af5509703db918682

Rotate circleci keys

e9442b0

Summary: Pull Request resolved: pytorch#19981 Differential Revision: D15174219 Pulled By: pjh5 fbshipit-source-id: 205952aa90ed93f193f40d4293f5a8d82fa33ed6

fix labs warning in THVectorDefault.cpp (pytorch#19999)

57db607

Summary: Pull Request resolved: pytorch#19999 ghimport-source-id: 81157c6 Differential Revision: D15169025 Pulled By: ljk53 fbshipit-source-id: 8e6f8df6dec6d21d6c7e743e974f4fcfff7cdeb5

fix labs warning in THTensorMoreMath.cpp (pytorch#19760)

410aeaf

Summary: Pull Request resolved: pytorch#19760 ghimport-source-id: d0aabee Differential Revision: D15087655 Pulled By: ljk53 fbshipit-source-id: ac133dfc2301c2a86c41b4b8f1483d7d23824e1e

Add suport for tensor targets in for-in (pytorch#19380)

c391567

Summary: Fixes pytorch#19314 Pull Request resolved: pytorch#19380 Differential Revision: D15167858 Pulled By: Krovatkin fbshipit-source-id: e87261bbf3e6f8df0601df80280eb3dba42798cd

Replace tab with space.

0189d2b

Avoid loading modules from torch.nn in transformer.py. clean some lint errors in transformer.py and test_nn.py. A few lint errors. Fix continuation line over-indented.

zhangguanheng66 force-pushed the transformer branch from c23dd64 to a108297 Compare May 6, 2019 16:12

zhangguanheng66 requested review from apaszke, ebetica, ezyang, fmassa, goldsborough, mrshenli, pietern and yf225 as code owners May 6, 2019 16:12

zhangguanheng66 closed this May 6, 2019

zhangguanheng66 mentioned this pull request May 6, 2019

nn.Transformer #20170

Closed

zhangguanheng66 deleted the transformer branch May 16, 2019 20:31

zhangguanheng66 changed the title ~~[WIP] Transformer~~ Transformer Jun 12, 2019

ksbsk mentioned this pull request Oct 30, 2019

Implementation of Self-Attention with Relative Position Representations allenai/allennlp#3398

Closed

Transformer #19274

Transformer #19274

Uh oh!

Conversation

zhangguanheng66 commented Apr 15, 2019

Uh oh!

zhangguanheng66 commented Apr 15, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cpuhrsch commented Apr 15, 2019

Uh oh!

cpuhrsch commented Apr 15, 2019

Uh oh!

cpuhrsch commented Apr 15, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MaksymDel May 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MaksymDel May 3, 2019 •

edited

Loading