Add aten mkldnn add operator #19207
Closed
Add aten mkldnn add operator #19207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D14889477 Differential Version: 79209394
This was referenced Apr 12, 2019
bddppq
added
the
module: mkldnn
Differential Revision: D14889477 Differential Version: 79296740
Differential Revision: D14889477 Differential Version: 79299279
Differential Revision: D14889477 Differential Version: 79689941
Differential Revision: D14889477 Differential Version: 79698403
Differential Revision: D14889477 Differential Version: 79729544
dzhulgakov
reviewed
Apr 19, 2019
Differential Revision: D14889477 Differential Version: 80386614
gchanan
approved these changes
Apr 23, 2019
Contributor
gchanan
left a comment
gchanan
left a comment
There was a problem hiding this comment.
approved once comments are addressed.
| ideep::tensor& y = itensor_from_mkldnn(other); | ||
|
|
||
| ideep::tensor& z = itensor_from_mkldnn(result); | ||
| const std::vector<float> scales{1.0, alpha.to<float>()}; |
Contributor
There was a problem hiding this comment.
do we ever worry about mkldnn supporting double? We could technically write this generically with a dispatch macro.
Contributor
Author
There was a problem hiding this comment.
ideep::sum::compute only takes scales as float vector
Differential Revision: D14889477 Differential Version: 80533697
Differential Revision: D14889477 Differential Version: 80534300
Differential Revision: D14889477 Differential Version: 80534911
Differential Revision: D14889477 Differential Version: 80541661
Differential Revision: D14889477 Differential Version: 80564052
Differential Revision: D14889477 Differential Version: 80580147
Differential Revision: D14889477 Differential Version: 80683615
dzhulgakov
approved these changes
Apr 25, 2019
Differential Revision: D14889477 Differential Version: 80773728
Differential Revision: D14889477 Differential Version: 80780050
Differential Revision: D14889477 Differential Version: 80785116
Differential Revision: D14889477 Differential Version: 80799725
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Apr 26, 2019
Summary: Pull Request resolved: pytorch/pytorch#19207 Reviewed By: dzhulgakov Differential Revision: D14889477 fbshipit-source-id: 2c5e5ea5dfc26a9c9a172c5fa2c6d7584b167e16
Contributor
|
This pull request has been merged in 61d5a8d. |
zhangguanheng66
pushed a commit
to zhangguanheng66/pytorch
that referenced
this pull request
May 6, 2019
Summary: Pull Request resolved: pytorch#19207 Reviewed By: dzhulgakov Differential Revision: D14889477 fbshipit-source-id: 2c5e5ea5dfc26a9c9a172c5fa2c6d7584b167e16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #19633 Add is_mkldnn to at::Tensor 💚
:white_circle: #19204 Add aten mkldnn conv2d operator 💚
:white_circle: #19205 Add aten mkldnn ops: relu, max_pool2d and avg_pool2d 💚
:white_circle: #19206 Add aten mkldnn batch_norm operator 💚
:black_circle: #19207 Add aten mkldnn add operator 💚
:white_circle: #19209 Add aten mkldnn view operator 💚
:white_circle: #19210 Add aten mkldnn linear operator 💚
:white_circle: #19648 Adjust resnext run script 💚
Pull Request resolved: #19207
Differential Revision: D14889477