Remove ProcessGroup::getGroupRank #19147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D14889736 Differential Version: 78975800
pietern
added
oncall: distributed
mrshenli
approved these changes
Apr 11, 2019
Contributor
mrshenli
left a comment
mrshenli
left a comment
There was a problem hiding this comment.
Test failure looks irrelevant:
Apr 11 05:59:22 ======================================================================
Apr 11 05:59:22 ERROR: test_module_copy_with_attributes (__main__.TestScript)
Apr 11 05:59:22 ----------------------------------------------------------------------
Apr 11 05:59:22 Traceback (most recent call last):
Apr 11 05:59:22 File "test_jit.py", line 3545, in test_module_copy_with_attributes
Apr 11 05:59:22 v = Vocabulary(list('uabcdefg'))
Apr 11 05:59:22 File "/opt/python/2.7/lib/python2.7/site-packages/torch/jit/__init__.py", line 987, in init_then_register
Apr 11 05:59:22 original_init(self, *args, **kwargs)
Apr 11 05:59:22 File "test_jit.py", line 3519, in __init__
Apr 11 05:59:22 super().__init__()
Apr 11 05:59:22 TypeError: super() takes at least 1 argument (0 given)
Apr 11 05:59:22
Apr 11 05:59:22 ----------------------------------------------------------------------
Contributor
|
@pytorchbot rebase this please |
Contributor
Author
|
The test failures were fixed by revert commit 5164622. |
Contributor
|
This pull request has been merged in c1b92f5. |
zhangguanheng66
pushed a commit
to zhangguanheng66/pytorch
that referenced
this pull request
May 6, 2019
Summary: Pull Request resolved: pytorch#19147 After pytorch#14809 was merged there is no longer a need for getGroupRank. Every ProcessGroup object has its own rank and size fields which are accurate for the global group as well as subgroups. Strictly speaking removing a function in a minor version bump is a big no-no, but I highly doubt this was ever used outside of `torch.distributed` itself. This will result in a compile error for folks who have subclassed the ProcessGroup class though. If this is a concern we can delay merging until a later point in time, but eventually this will need to be cleaned up. Differential Revision: D14889736 fbshipit-source-id: 3846fe118b3265b50a10ab8b1c75425dad06932d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #19147 Remove ProcessGroup::getGroupRank 💛
After #14809 was merged there is no longer a need for getGroupRank.
Every ProcessGroup object has its own rank and size fields which are
accurate for the global group as well as subgroups.
Strictly speaking removing a function in a minor version bump is a big
no-no, but I highly doubt this was ever used outside of
torch.distributeditself. This will result in a compile error forfolks who have subclassed the ProcessGroup class though.
If this is a concern we can delay merging until a later point in time,
but eventually this will need to be cleaned up.
Differential Revision: D14889736