[jit] math module support #19115
Closed
[jit] math module support #19115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
Contributor
|
Ideally we'd be able to bind the |
driazati
reviewed
Apr 11, 2019
torch/csrc/jit/register_prim_ops.cpp
Outdated
| }), | ||
|
|
||
| Operator( | ||
| "aten::ceil(float a) -> int", |
Contributor
There was a problem hiding this comment.
This should return a float (and could you change aten::floor above to also return a float)? Casting a float to an int may truncate the value if its bigger than std::numeric_limits<int64_t>::max(). It's safer to make the user explicitly agree to truncate.
@torch.jit.script
def double_floor(x):
# type: (float) -> float
return x - x % 1
@torch.jit.script
def int_floor(x):
# type: (float) -> int
return int(x - x % 1)
print(double_floor(1.2))
print(int_floor(1.2))
print(double_floor(float(5e29)))
print(int_floor(float(5e29))) # incorrect in torchscript
driazati
approved these changes
Apr 12, 2019
test/test_jit.py
Outdated
| return math.pow(2.0, 2.0) | ||
|
|
||
| def test_pow_int(): | ||
| return math.pow(2.0, 2) |
Contributor
There was a problem hiding this comment.
For all these tests could you refactor them to take in an input instead of using a literal? This will let us test different values more easily.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 19, 2019
Summary: Fixes: #19253 Fixing pow(Tensor, float) is straightforward. The breakage for pow(float, Tensor) is a bit more subtle to trigger, and fixing needs `torch.log` (`math.log` didn't work) from the newly merged #19115 (Thanks ngimel for pointing out this has landed.) Pull Request resolved: #19324 Differential Revision: D15003531 Pulled By: ailzhang fbshipit-source-id: 8b22138fa27a43806b82886fb3a7b557bbb5a865
zhangguanheng66
pushed a commit
to zhangguanheng66/pytorch
that referenced
this pull request
May 6, 2019
Summary: This PR refer to issue [pytorch#19026](pytorch#19026) Pull Request resolved: pytorch#19115 Differential Revision: D14936053 Pulled By: driazati fbshipit-source-id: 68d5f33ced085fcb8c10ff953bc7e99df055eccc
zhangguanheng66
pushed a commit
to zhangguanheng66/pytorch
that referenced
this pull request
May 6, 2019
Summary: Fixes: pytorch#19253 Fixing pow(Tensor, float) is straightforward. The breakage for pow(float, Tensor) is a bit more subtle to trigger, and fixing needs `torch.log` (`math.log` didn't work) from the newly merged pytorch#19115 (Thanks ngimel for pointing out this has landed.) Pull Request resolved: pytorch#19324 Differential Revision: D15003531 Pulled By: ailzhang fbshipit-source-id: 8b22138fa27a43806b82886fb3a7b557bbb5a865
xiaomengy
pushed a commit
to xiaomengy/pytorch
that referenced
this pull request
May 28, 2019
Summary: Not much to say. Fixes implementation introduced here: pytorch#19115 Pull Request resolved: pytorch#21041 Differential Revision: D15528801 Pulled By: Chillee fbshipit-source-id: bacd709eb711ca00156bd70480d6051b437517ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refer to issue #19026