-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Port TH library to ATen/Parallel #19105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This PR implements changes described in #19001
Move OMP/MKL thread initialization into ATen/Parallel Summary: This PR implements changes described in #19001 gh-metadata: pytorch pytorch 19011 gh/ilia-cher/1/head
Move OMP/MKL thread initialization into ATen/Parallel Summary: This PR implements changes described in #19001 gh-metadata: pytorch pytorch 19011 gh/ilia-cher/1/head
Move OMP/MKL thread initialization into ATen/Parallel Summary: This PR implements changes described in #19001 gh-metadata: pytorch pytorch 19011 gh/ilia-cher/1/head
Move OMP/MKL thread initialization into ATen/Parallel Summary: This PR implements changes described in #19001 gh-metadata: pytorch pytorch 19011 gh/ilia-cher/1/head
Move OMP/MKL thread initialization into ATen/Parallel Summary: This PR implements changes described in #19001 gh-metadata: pytorch pytorch 19011 gh/ilia-cher/1/head
Summary: Similar to initialization in torch initModule and autograd's Engine::thread_init, we need to call at::init_num_threads when initializing JIT thread pool threads
Move OMP/MKL thread initialization into ATen/Parallel Summary: This PR implements changes described in #19001 gh-metadata: pytorch pytorch 19011 gh/ilia-cher/1/head
Initialize intra-op threads in JIT thread pool Summary: Similar to initialization in torch initModule and autograd's Engine::thread_init, we need to call at::init_num_threads when initializing JIT thread pool threads gh-metadata: pytorch pytorch 19058 gh/ilia-cher/2/head
Summary: Removing explicit usage of OpenMP from TH. More details in #19002 Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch
Move OMP/MKL thread initialization into ATen/Parallel Summary: This PR implements changes described in #19001 gh-metadata: pytorch pytorch 19011 gh/ilia-cher/1/head
Initialize intra-op threads in JIT thread pool Summary: Similar to initialization in torch initModule and autograd's Engine::thread_init, we need to call at::init_num_threads when initializing JIT thread pool threads gh-metadata: pytorch pytorch 19058 gh/ilia-cher/2/head
Port TH library to ATen/Parallel Summary: Removing explicit usage of OpenMP from TH. More details in #19002 Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 19105 gh/ilia-cher/3/head
Move OMP/MKL thread initialization into ATen/Parallel Summary: This PR implements changes described in #19001 gh-metadata: pytorch pytorch 19011 gh/ilia-cher/1/head
Initialize intra-op threads in JIT thread pool Summary: Similar to initialization in torch initModule and autograd's Engine::thread_init, we need to call at::init_num_threads when initializing JIT thread pool threads gh-metadata: pytorch pytorch 19058 gh/ilia-cher/2/head
Port TH library to ATen/Parallel Summary: Removing explicit usage of OpenMP from TH. More details in #19002 Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 19105 gh/ilia-cher/3/head
Move OMP/MKL thread initialization into ATen/Parallel Summary: This PR implements changes described in #19001 gh-metadata: pytorch pytorch 19011 gh/ilia-cher/1/head
Initialize intra-op threads in JIT thread pool Summary: Similar to initialization in torch initModule and autograd's Engine::thread_init, we need to call at::init_num_threads when initializing JIT thread pool threads gh-metadata: pytorch pytorch 19058 gh/ilia-cher/2/head
Port TH library to ATen/Parallel Summary: Removing explicit usage of OpenMP from TH. More details in #19002 Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 19105 gh/ilia-cher/3/head
Move OMP/MKL thread initialization into ATen/Parallel Summary: This PR implements changes described in #19001 gh-metadata: pytorch pytorch 19011 gh/ilia-cher/1/head
Initialize intra-op threads in JIT thread pool Summary: Similar to initialization in torch initModule and autograd's Engine::thread_init, we need to call at::init_num_threads when initializing JIT thread pool threads gh-metadata: pytorch pytorch 19058 gh/ilia-cher/2/head
Port TH library to ATen/Parallel Summary: Removing explicit usage of OpenMP from TH. More details in #19002 Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 19105 gh/ilia-cher/3/head
…pool" Initialize intra-op threads in JIT thread pool Summary: Similar to initialization in torch initModule and autograd's Engine::thread_init, we need to call at::init_num_threads when initializing JIT thread pool threads gh-metadata: pytorch pytorch 19058 gh/ilia-cher/2/head
Contributor
Author
|
rebased on top of #19997 |
Port TH library to ATen/Parallel Summary: Removing explicit usage of OpenMP from TH. More details in #19002 Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 19105 gh/ilia-cher/3/head
Port TH library to ATen/Parallel Summary: Removing explicit usage of OpenMP from TH. More details in #19002 Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 19105 gh/ilia-cher/3/head
This was referenced May 1, 2019
Port TH library to ATen/Parallel Summary: Removing explicit usage of OpenMP from TH. More details in #19002 Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 19105 gh/ilia-cher/3/head
Contributor
Author
Port TH library to ATen/Parallel Summary: Removing explicit usage of OpenMP from TH. More details in #19002 Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 19105 gh/ilia-cher/3/head
Port TH library to ATen/Parallel Summary: Removing explicit usage of OpenMP from TH. More details in #19002 Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 19105 gh/ilia-cher/3/head
Port TH library to ATen/Parallel Summary: Removing explicit usage of OpenMP from TH. More details in #19002 Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 19105 gh/ilia-cher/3/head
Port TH library to ATen/Parallel Summary: Removing explicit usage of OpenMP from TH. More details in #19002 Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 19105 gh/ilia-cher/3/head
Port TH library to ATen/Parallel Summary: Removing explicit usage of OpenMP from TH. More details in #19002 Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 19105 gh/ilia-cher/3/head
Port TH library to ATen/Parallel Summary: Removing explicit usage of OpenMP from TH. More details in #19002 Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 19105 gh/ilia-cher/3/head
Port TH library to ATen/Parallel Summary: Removing explicit usage of OpenMP from TH. More details in #19002 Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 19105 gh/ilia-cher/3/head
VitalyFedyunin
approved these changes
May 7, 2019
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--- nvm ----
Port TH library to ATen/Parallel Summary: Removing explicit usage of OpenMP from TH. More details in #19002 Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 19105 gh/ilia-cher/3/head
Port TH library to ATen/Parallel Summary: Removing explicit usage of OpenMP from TH. More details in #19002 Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 19105 gh/ilia-cher/3/head
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
May 8, 2019
Summary: Pull Request resolved: pytorch/pytorch#19105 ghimport-source-id: db3e26f89d098e86215c48e464ace615193f5772 Differential Revision: D14947557 Pulled By: ilia-cher fbshipit-source-id: 7e987e74c034646ba818f02e7bd711aba2ee3364
Contributor
|
@ilia-cher merged this pull request in 0ebe252. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Removing explicit usage of OpenMP from TH.
More details in #19002
Test Plan:
BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake
pytest -s -v test/test_torch.py::TestTorch
Differential Revision: D14947557