Сhange type of a tensor with bools #19097
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@gchanan, i think this shows the JIT issue that you were mentioning yesterday. the failing test(test_jit.py::test_torch_tensor) shows that JIT.CompilationUnit is behaving differently. Should i update JITs logic or is it a BC issue and i should add a deprecation warning instead? |
gchanan
reviewed
Apr 11, 2019
| if (PyBool_Check(obj)) { | ||
| // TODO: infer Bool when we have Bool ScalarType | ||
| return ScalarType::Byte; | ||
| return ScalarType::Bool; |
Contributor
There was a problem hiding this comment.
all of the non-test changes besides this look correct and can go in (because they don't break backcompat), right?
Contributor
|
you should figure out where the JIT logic is first. |
izdeby
force-pushed
the
changeTypeOfATensorWithBools
branch
from
5d36304 to
4947864
Compare
izdeby
force-pushed
the
changeTypeOfATensorWithBools
branch
from
4947864 to
59824ea
Compare
pytorchbot
added
oncall: jit
eellison
reviewed
Jun 4, 2019
izdeby
changed the title
izdeby
requested review from
VitalyFedyunin,
eellison,
ezyang and
gchanan
and removed request for
gchanan
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@izdeby has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
approved these changes
Jun 4, 2019
Contributor
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 5, 2019
Summary: **This is **bc-breaking** change** Change dtype of a tensor which was created from bool data. Old behavior: torch.tensor([True, False]) -> uint8 tensor Now: torch.tensor([True, False]) -> bool tensor Tested via tests. Pull Request resolved: pytorch/pytorch#19097 Reviewed By: ezyang Differential Revision: D15632553 Pulled By: izdeby fbshipit-source-id: b019150844c561a6845710a3c62b12f06b68bbe3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is bc-breaking change
Change dtype of a tensor which was created from bool data.
Old behavior: torch.tensor([True, False]) -> uint8 tensor
Now: torch.tensor([True, False]) -> bool tensor
Tested via tests.