Fix Windows target determination for POSIX changed-file paths#188961
Closed
VectorPeak wants to merge 2 commits into
Closed
Fix Windows target determination for POSIX changed-file paths#188961VectorPeak wants to merge 2 commits into
VectorPeak wants to merge 2 commits into
Conversation
Authored with assistance from an AI assistant; reviewed by the contributor.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/188961
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7f852d9 with merge base 5abd860 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
approved these changes
Jul 6, 2026
Collaborator
|
@VectorPeak if you plan to submit more such changes, please keep your PR descriptions succinct |
Collaborator
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Contributor
Author
|
sorry，my bad……
Nikita Shulga ***@***.***> 于 2026年7月6日周一 下午8:10写道：
… *malfet* left a comment (pytorch/pytorch#188961)
<#188961 (comment)>
@pytorchbot <https://github.com/pytorchbot> merge
—
Reply to this email directly, view it on GitHub
<#188961?email_source=notifications&email_token=ARNKG5XRXZPQWD7GUV2UZKD5DOJKHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBZGI3DANJUHAY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4892605481>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARNKG5V5WUWLVDKESVORUDT5DOJKHAVCNFSNUABEKJSXA33TNF2G64TZHM3DKNRQGA4TONJ3JFZXG5LFHM2DQMJRGM4DANZUGKQXMAQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
vishalgoyal316
pushed a commit
to vishalgoyal316/pytorch
that referenced
this pull request
Jul 16, 2026
…h#188961) `tools/testing/modulefinder_determinator.py` interprets changed-file paths when deciding whether slow tests need to run. Git and GitHub report changed files as repository-relative POSIX-style paths such as `torch/utils/cpp_extension.py`, even when the target determination code runs on Windows. Before this change, modulefinder target determination split those paths with `os.sep`. On Windows, `os.sep` is `\`, so a Git-style path containing `/` stayed as one component and could be classified as `UNKNOWN` instead of `TORCH`, `TEST`, `CAFFE2`, or `CI`. `UNKNOWN` files conservatively trigger tests more broadly, so Windows runs could lose a useful target-determination signal and run more tests than necessary. Fixes pytorch#188960 Pull Request resolved: pytorch#188961 Approved by: https://github.com/malfet
DamJanusz
pushed a commit
to DamJanusz/pytorch
that referenced
this pull request
Jul 21, 2026
…h#188961) `tools/testing/modulefinder_determinator.py` interprets changed-file paths when deciding whether slow tests need to run. Git and GitHub report changed files as repository-relative POSIX-style paths such as `torch/utils/cpp_extension.py`, even when the target determination code runs on Windows. Before this change, modulefinder target determination split those paths with `os.sep`. On Windows, `os.sep` is `\`, so a Git-style path containing `/` stayed as one component and could be classified as `UNKNOWN` instead of `TORCH`, `TEST`, `CAFFE2`, or `CI`. `UNKNOWN` files conservatively trigger tests more broadly, so Windows runs could lose a useful target-determination signal and run more tests than necessary. Fixes pytorch#188960 Pull Request resolved: pytorch#188961 Approved by: https://github.com/malfet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/testing/modulefinder_determinator.pyinterprets changed-file paths when deciding whether slow tests need to run. Git and GitHub report changed files as repository-relative POSIX-style paths such astorch/utils/cpp_extension.py, even when the target determination code runs on Windows.Before this change, modulefinder target determination split those paths with
os.sep. On Windows,os.sepis\, so a Git-style path containing/stayed as one component and could be classified asUNKNOWNinstead ofTORCH,TEST,CAFFE2, orCI.UNKNOWNfiles conservatively trigger tests more broadly, so Windows runs could lose a useful target-determination signal and run more tests than necessary.Fixes #188960