FYI I have a fix for promotion of scalar types in binary operators: #18811

Not sure if this was surfaced by this test or not

The tests with scalar failures were test_rand, test_inplace_copy_script, and test_mutable_dce_wildcards.

#18812 should fix inplace_copy and test_mutable_dce_wildcards and it looks like your PR will probably fix test_rand.

The remaining failure is test_time_sequence_prediction, which when run with this PR:

%37 : Tensor[] = prim::ListConstruct(%35, %36)
 = test::check_dim_tensor(%46)
 = test::check_dim_tensor(%45)
 = test::check_dim_tensor(%44)
 = test::check_dim_tensor(%43)
 = test::check_dim_tensor(%41)
%38 : Tensor, %39 : Tensor = aten::lstm_cell(%41, %37, %43, %44, %45, %46)

test::check_dim_tensor(%45) fails, but I haven't figured out why yet.

Actually jk i don't think the test_rand failure is related to your diff

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
Stale pull requests will automatically be closed 30 days after being marked Stale