Support out-of-place broadcast type definitions. #1869
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
this is now merged into master |
houseroad
added a commit
to houseroad/pytorch
that referenced
this pull request
Apr 25, 2019
…f33179 Summary: Previous import was 0e8d2bc5e51455c70ef790b9f65aa632ed9bc8a7 Included changes: - **[27d4b617](onnx/onnx@27d4b617)**: Adding RoIAlign operator (pytorch#1869) <Sam Pepose> - **[70c9026c](onnx/onnx@70c9026c)**: add ReverseSequence op (pytorch#1927) <Guoliang Hua> - **[ed2db02a](onnx/onnx@ed2db02a)**: README.md: Update badge style for build status (pytorch#1942) <Yulong Wang> - **[e36d3b54](onnx/onnx@e36d3b54)**: Enable python 3.7 in CI for Windows (pytorch#1943) <Raymond Yang> Differential Revision: D15077516 fbshipit-source-id: 8c02c113f1c7da8177a88759809970cd9f72ba00
xiaomengy
pushed a commit
to xiaomengy/pytorch
that referenced
this pull request
Apr 25, 2019
…f33179 (pytorch#19718) Summary: Pull Request resolved: pytorch#19718 Previous import was 0e8d2bc5e51455c70ef790b9f65aa632ed9bc8a7 Included changes: - **[27d4b617](onnx/onnx@27d4b617)**: Adding RoIAlign operator (pytorch#1869) <Sam Pepose> - **[70c9026c](onnx/onnx@70c9026c)**: add ReverseSequence op (pytorch#1927) <Guoliang Hua> - **[ed2db02a](onnx/onnx@ed2db02a)**: README.md: Update badge style for build status (pytorch#1942) <Yulong Wang> - **[e36d3b54](onnx/onnx@e36d3b54)**: Enable python 3.7 in CI for Windows (pytorch#1943) <Raymond Yang> Differential Revision: D15077516 fbshipit-source-id: c8c6935381ff5a96ab9a4ee519685814f4ea6e59
zhangguanheng66
pushed a commit
to zhangguanheng66/pytorch
that referenced
this pull request
May 6, 2019
…f33179 (pytorch#19718) Summary: Pull Request resolved: pytorch#19718 Previous import was 0e8d2bc5e51455c70ef790b9f65aa632ed9bc8a7 Included changes: - **[27d4b617](onnx/onnx@27d4b617)**: Adding RoIAlign operator (pytorch#1869) <Sam Pepose> - **[70c9026c](onnx/onnx@70c9026c)**: add ReverseSequence op (pytorch#1927) <Guoliang Hua> - **[ed2db02a](onnx/onnx@ed2db02a)**: README.md: Update badge style for build status (pytorch#1942) <Yulong Wang> - **[e36d3b54](onnx/onnx@e36d3b54)**: Enable python 3.7 in CI for Windows (pytorch#1943) <Raymond Yang> Differential Revision: D15077516 fbshipit-source-id: c8c6935381ff5a96ab9a4ee519685814f4ea6e59
apakbin
pushed a commit
to apakbin/pytorch
that referenced
this pull request
Feb 18, 2025
…orch#144865) (pytorch#1869) Fixes pytorch#144855 Follows approach in pytorch#141923 to use int64 types to increase INT_MAX limits Pull Request resolved: pytorch#144865 Approved by: https://github.com/eqy (cherry picked from commit 082fab0)
jagadish-amd
pushed a commit
to jagadish-amd/pytorch
that referenced
this pull request
May 8, 2025
…orch#144865) (pytorch#1869) Fixes pytorch#144855 Follows approach in pytorch#141923 to use int64 types to increase INT_MAX limits Pull Request resolved: pytorch#144865 Approved by: https://github.com/eqy (cherry picked from commit 082fab0) (cherry picked from commit 5d01868)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means you can specify the types of the arguments to be expanded in a "broadcast:" definition, for cases where the types aren't THTensor. We previously only allowed this for in-place functions, but we are now allowing for out-of-place functions. Note we could detect types in the Broadcast plugin itself, but then we'd have to add parameter checking. Right now the Broadcast Plugin is simple and the definitions are self contained.
This functionality isn't currently exposed, but: