Update cpp_extension.py #18638
Closed
Update cpp_extension.py #18638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Append `extra_cuda_cflags` when building in Windows environment
BloodAxe
requested review from
apaszke,
ezyang,
fmassa,
goldsborough and
soumith
as code owners
soumith
approved these changes
Mar 29, 2019
Contributor
soumith
left a comment
soumith
left a comment
There was a problem hiding this comment.
thanks for figuring this out and fixing it.
Contributor
|
@pytorchbot merge this please |
1 similar comment
Collaborator
|
@pytorchbot merge this please |
pytorchbot
added
the
merge-this-please
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. It seems that when building CPP-extensions with CUDA for Windows, an
extra_cuda_cflagsoptions are not properly forwarded tonvcc.Use of extra CUDA options is necessary to build, for instance, a InplaceABN (https://github.com/mapillary/inplace_abn), which requires
--expt-extended-lambdaoption.This PR adds one line that correctly appends
extra_cuda_cflags.