Skip to content

Fix bug of threshold activation #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soumith merged 1 commit into from
Jun 22, 2017
Merged

Fix bug of threshold activation #1863

soumith merged 1 commit into from
Jun 22, 2017

Conversation

@LiZhaoxing
Copy link
Contributor

@LiZhaoxing LiZhaoxing commented Jun 21, 2017

Fix the issue #1860 .

Due to my fault of last implementation PR #1507 . :(
The logic of here is wrong.

torch/nn/_functions/thnn/activation.py

         else:
             grad_input = grad_output.masked_fill(input > ctx.threshold, 0)
         return grad_input, None, None, None
And this will cause some innormal value in my application.

The implementation is doing in the opposite way. The implementation should be grad_output.masked_fill(input <= ctx.threshold, 0)

@soumith soumith merged commit 3f6cda8 into pytorch:master Jun 22, 2017
@caogang caogang deleted the fixbug_threshold branch June 23, 2017 00:52
jagadish-amd added a commit to jagadish-amd/pytorch that referenced this pull request Feb 5, 2025
@jagadish-amd
[reland][AMD] Turn on TF32 for aten::mm (pytorch#1863)
f7ad58f 
Ported upstream PR

Signed-off-by: Jagadish Krishnamoorthy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@apaszke apaszke apaszke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LiZhaoxing @apaszke @ezyang @soumith