Add numpy like repeat as torch.repeat_interleave #18395
Conversation
|
Thanks for doing this! I think we should name it something other than |
|
@ssnl I was thinking about |
apaszke
left a comment
apaszke
left a comment
There was a problem hiding this comment.
numpy_repeat is not a good name. Maybe repeat_interleave?
|
@apaszke |
zasdfgbnm
changed the title
|
@pytorchbot retest this please |
|
CC @umanwizard. |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Just resolved a merge conflict. |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
It failed internal tests but it's not your fault. |
|
@umanwizard can you please rebase the internal diff and reland it? |
|
@pytorchbot rebase this please |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@umanwizard is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@umanwizard is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Sorry, I have been trying to land this for the last few days and keep running into issues. Just commenting here @zasdfgbnm to let you know I haven't forgotten about it. |
|
@umanwizard Thanks for letting me know! Just take your time, and let me know if there is anything I can help. |
Summary: Fixes: pytorch/pytorch#14093 cc: SsnL Pull Request resolved: pytorch/pytorch#18395 Differential Revision: D14599509 Pulled By: umanwizard fbshipit-source-id: 2391a1cc135fe5bab38475f1c8ed87c4a96222f3
|
@umanwizard merged this pull request in 8c9caf1. |
Summary: Fixes: pytorch#14093 cc: SsnL Pull Request resolved: pytorch#18395 Differential Revision: D14599509 Pulled By: umanwizard fbshipit-source-id: 2391a1cc135fe5bab38475f1c8ed87c4a96222f3
8 participants
Fixes: #14093
cc: @ssnl