[ONNX] Proposing custom ops support in ONNX exporter #18297
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TODO: adding more checks
BowenBao
force-pushed
the
onnx_custom_ops_sync
branch
from
3eedac3 to
7bcab3a
Compare
houseroad
requested changes
Apr 2, 2019
Member
houseroad
left a comment
houseroad
left a comment
There was a problem hiding this comment.
This is a great move. Thanks for adding the support for custom op. It will benefits more users.
- please address the inline comments
- add a test case, probably in test/onnx/test_operators.py
- add appropriate docs
| return getattr(self, sel)(k) | ||
|
|
||
| def register_custom_op_symbolic(symbolic_name, symbolic_fn): | ||
| ns, op_name = symbolic_name.split('::') |
Member
There was a problem hiding this comment.
Add assertion to check the format of the symbolic_name, should be domain::op.
Also, we need to check the domain doesn't conflict with existing domain
Collaborator
Author
|
Thanks for the comments @houseroad! Closing this PR now that it is covered in #19294 |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 11, 2019
Summary: Support exporting multiple ONNX opsets (more specifically opset 10 for now), following the proposal in https://gist.github.com/spandantiwari/99700e60919c43bd167838038d20f353. And add support for custom ops (merge with #18297). This PR will be followed by another PR containing the changes related to testing the ops for different opsets. Pull Request resolved: #19294 Reviewed By: zrphercule Differential Revision: D15043951 Pulled By: houseroad fbshipit-source-id: d336fc35b8827145639137bc348ae07e3c14bb1c
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
May 11, 2019
Summary: Support exporting multiple ONNX opsets (more specifically opset 10 for now), following the proposal in https://gist.github.com/spandantiwari/99700e60919c43bd167838038d20f353. And add support for custom ops (merge with pytorch/pytorch#18297). This PR will be followed by another PR containing the changes related to testing the ops for different opsets. Pull Request resolved: pytorch/pytorch#19294 Reviewed By: zrphercule Differential Revision: D15043951 Pulled By: houseroad fbshipit-source-id: d336fc35b8827145639137bc348ae07e3c14bb1c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this tutorial torch script custom ops, users have created their custom ops implementation and registered in PyTorch.
With this PR, users will be able to provide their own symbolic function for their custom ops.
And proceed to export to ONNX as usual.