Move pyobj_ to TensorImpl #18225
Closed
Move pyobj_ to TensorImpl #18225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 20, 2019 12:02
22 tasks
ezyang
approved these changes
Mar 20, 2019
gchanan
reviewed
Mar 20, 2019
Contributor
|
can you improve the description? It says The link to the description doesn't elucidate the situation either: |
gchanan
approved these changes
Mar 21, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
THPVariable_Wrap(…)andTHPVariable_NewWithVar(…)depend on the existence ofpyobj_in the autograd metadata of a Variable to convert the Variable to a Python tensor. However, after the Variable/Tensor merge, there will be Variables that don't contain autograd metadata, and to allow the conversion from non-autograd-meta Variable to a Python tensor we need to store thepyobj_outside of autograd metadata and in a place where it will always be available.This PR makes it possible by moving
pyobj_into TensorImpl, so thatTHPVariable_Wrap(…)andTHPVariable_NewWithVar(…)can always access a Variable'spyobj_and convert the Variable to a Python tensor.