Skip to content

Conversation

@BowenBao
Copy link
Collaborator

Set value as tensor of 1 element instead of scalar, according to ONNX spec.

@ezyang ezyang requested a review from houseroad March 20, 2019 15:47
@BowenBao BowenBao force-pushed the onnx_constant_ops branch from c347c1f to 7ab7de0 Compare March 20, 2019 16:37
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@BowenBao BowenBao force-pushed the onnx_constant_ops branch from 7ab7de0 to fc25df4 Compare March 25, 2019 22:29
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@houseroad merged this pull request in 654e59f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants