Added the exception of ignore_index #18117
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think the wording here is still confusing. @tomahawk810, do you have any opinions here? |
|
I think it helps but indeed the wording could be more accurate. I find the "except" not ideal.
|
Contributor
|
@tomahawk810 I copy-edited it some more. Please take a look and see if it looks clear to you. |
|
@ezyang looks good to me. Note that there is a typo: a double ";" on line 856 |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17801 to add an exception regarding
ignore_indexin the documentation fortorch.nn.CrossEntropyLossandtorch.nn.NLLLossIf any other files/functions are hit, I'd be glad to incorporate the changes there too! 😊