Add onnx export for floor, ceil, log2 and prim::shape #17895
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BowenBao
force-pushed
the
onnx_floor_etc
branch
2 times, most recently
from
9a6ae65 to
fd70d56
Compare
houseroad
reviewed
Apr 2, 2019
houseroad
reviewed
Apr 2, 2019
Member
houseroad
left a comment
houseroad
left a comment
There was a problem hiding this comment.
Thanks for the PR. Please address inline comments.
torch/onnx/symbolic.py
Outdated
Member
There was a problem hiding this comment.
can we also add a test case for this one?
BowenBao
force-pushed
the
onnx_floor_etc
branch
4 times, most recently
from
a6f3547 to
3001465
Compare
add test for prim_shape nit remove ceil, floor symbolic due to already resolved merge
BowenBao
force-pushed
the
onnx_floor_etc
branch
from
3001465 to
48311d5
Compare
houseroad
reviewed
Apr 25, 2019
| return g.op('Div', log(g, self), g.op('Constant', value_t=torch.Tensor([_ln2]))) | ||
|
|
||
|
|
||
| def prim_shape(g, self): |
Member
There was a problem hiding this comment.
Interesting, I am wondering why this would work with prim::shape node.
Member
There was a problem hiding this comment.
I need to think about whether this is a good way to handle prim::nodes
houseroad
approved these changes
Apr 26, 2019
Member
houseroad
left a comment
houseroad
left a comment
There was a problem hiding this comment.
Looks good.
Once we add support for custom domain op, we should refactor prim domain op.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@houseroad merged this pull request in 8e77506. |
zhangguanheng66
pushed a commit
to zhangguanheng66/pytorch
that referenced
this pull request
May 6, 2019
Summary: Pull Request resolved: pytorch#17895 Reviewed By: zrphercule Differential Revision: D15103396 Pulled By: houseroad fbshipit-source-id: 2ec80f11a19a8659aa496e68aed769a8dd1efb18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.