Add ScalarType arg to Type::options() #17787
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D14379076 Differential Version: 74694649
li-roy
requested review from
apaszke,
ebetica,
goldsborough,
mrshenli,
pietern and
yf225
as code owners
This was referenced Mar 8, 2019
facebook-github-bot
added
the
oncall: jit
added 3 commits
March 7, 2019 18:19
Differential Revision: D14379076 Differential Version: 74711131
Differential Revision: D14379076 Differential Version: 74714418
Differential Revision: D14379076 Differential Version: 74716820
added 8 commits
March 7, 2019 21:43
Differential Revision: D14379076 Differential Version: 74726485
Differential Revision: D14379076 Differential Version: 74726654
Differential Revision: D14379076 Differential Version: 74808629
Differential Revision: D14379076 Differential Version: 74811457
Differential Revision: D14379076 Differential Version: 74818458
Differential Revision: D14379076 Differential Version: 74831195
Differential Revision: D14379076 Differential Version: 74843002
Differential Revision: D14379076 Differential Version: 74983515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #17530 Small clean up of aten_op 💚
:white_circle: #17601 Store ScalarType and Backend instead of Type in TensorIterator 💚
:white_circle: #17785 Remove Type::elementSizeInBytes 💚
:white_circle: #17723 Store python default type as PyTensorType instead of at::Type 💚
:white_circle: #17786 Pass ScalarType separately from Type in python constructors 💚
:white_circle: #17792 Remove Type::ScalarType() 💚
:white_circle: #17603 Remove conversion operator from Type to TensorOptions 💛
:black_circle: #17787 Add ScalarType arg to Type::options() 💛
Differential Revision: D14379076