Remove Type::elementSizeInBytes #17785
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
February 26, 2019 14:15
Differential Revision: D14233250 Differential Version: 73474786
Differential Revision: D14233250 Differential Version: 73486177
Differential Revision: D14235395 Differential Version: 73486176
Differential Revision: D14237932 Differential Version: 73508674
Differential Revision: D14237931 Differential Version: 73508673
Differential Revision: D14235395 Differential Version: 73589963
Differential Revision: D14237932 Differential Version: 73589962
Differential Revision: D14237931 Differential Version: 73589961
Differential Revision: D14237932 Differential Version: 73659349
Differential Revision: D14237931 Differential Version: 73659351
Differential Revision: D14237932 Differential Version: 73714105
Differential Revision: D14237931 Differential Version: 73714104
Differential Revision: D14274754 Differential Version: 73828025
Differential Revision: D14274754 Differential Version: 73946909
Differential Revision: D14274754 Differential Version: 74349068
Differential Revision: D14235395 Differential Version: 74395307
Differential Revision: D14233250 Differential Version: 74395306
Differential Revision: D14237932 Differential Version: 74395305
Differential Revision: D14237931 Differential Version: 74395302
Differential Revision: D14274754 Differential Version: 74395303
Differential Revision: D14235395 Differential Version: 74488005
Differential Revision: D14237932 Differential Version: 74488004
Differential Revision: D14237931 Differential Version: 74488002
Differential Revision: D14274754 Differential Version: 74488003
Differential Revision: D14233250 Differential Version: 74537076
Differential Revision: D14235395 Differential Version: 74537072
Differential Revision: D14237932 Differential Version: 74537073
Differential Revision: D14237931 Differential Version: 74537071
Differential Revision: D14274754 Differential Version: 7453707
Differential Revision: D14233250 Differential Version: 74694645
added 13 commits
March 8, 2019 13:27
Differential Revision: D14379074 Differential Version: 74811461
Differential Revision: D14235395 Differential Version: 74818459
Differential Revision: D14237932 Differential Version: 74818452
Differential Revision: D14237931 Differential Version: 74818453
Differential Revision: D14274754 Differential Version: 74818462
Differential Revision: D14379074 Differential Version: 74818460
Differential Revision: D14237931 Differential Version: 74843005
Differential Revision: D14274754 Differential Version: 74842999
Differential Revision: D14379074 Differential Version: 74843000
Differential Revision: D14237931 Differential Version: 74983509
Differential Revision: D14274754 Differential Version: 74983510
Differential Revision: D14379074 Differential Version: 74983508
Differential Revision: D14379074 Differential Version: 75120335
added 2 commits
March 11, 2019 22:41
Differential Revision: D14379074 Differential Version: 75128945
Differential Revision: D14379074 Differential Version: 75194114
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Mar 15, 2019
Summary: Pull Request resolved: pytorch/pytorch#17785 Reviewed By: ezyang Differential Revision: D14379074 fbshipit-source-id: 60727f187d61eb571b144bd6eed4dd4908da0b51
labor00
pushed a commit
to labor00/horovod
that referenced
this pull request
Mar 16, 2019
labor00
pushed a commit
to labor00/horovod
that referenced
this pull request
Mar 16, 2019
…torch/pytorch#17785 Signed-off-by: labor00 <[email protected]>
labor00
pushed a commit
to labor00/horovod
that referenced
this pull request
Mar 18, 2019
…torch/pytorch#17785 Signed-off-by: labor00 <[email protected]>
alsrgv
pushed a commit
to horovod/horovod
that referenced
this pull request
Mar 18, 2019
#919) * from elementSizeInBytes to element_size, following upstream commit pytorch/pytorch#17785 Signed-off-by: labor00 <[email protected]> * uses TORCH_VERSION macro to ensure backward compatibility Signed-off-by: labor00 <[email protected]> * if pytorch version string contains dev return a very big number Signed-off-by: labor00 <[email protected]>
shirosankaku
pushed a commit
to SmorkalovME/horovod
that referenced
this pull request
May 30, 2019
horovod#919) * from elementSizeInBytes to element_size, following upstream commit pytorch/pytorch#17785 Signed-off-by: labor00 <[email protected]> * uses TORCH_VERSION macro to ensure backward compatibility Signed-off-by: labor00 <[email protected]> * if pytorch version string contains dev return a very big number Signed-off-by: labor00 <[email protected]> Signed-off-by: Yana Shchyokotova <[email protected]>
zsh-thu
pushed a commit
to zsh-thu/horovod
that referenced
this pull request
Jun 3, 2019
horovod#919) * from elementSizeInBytes to element_size, following upstream commit pytorch/pytorch#17785 Signed-off-by: labor00 <[email protected]> * uses TORCH_VERSION macro to ensure backward compatibility Signed-off-by: labor00 <[email protected]> * if pytorch version string contains dev return a very big number Signed-off-by: labor00 <[email protected]> Signed-off-by: Sihan Zeng <[email protected]>
jeffdaily
pushed a commit
to ROCm/horovod
that referenced
this pull request
Nov 27, 2019
horovod#919) * from elementSizeInBytes to element_size, following upstream commit pytorch/pytorch#17785 Signed-off-by: labor00 <[email protected]> * uses TORCH_VERSION macro to ensure backward compatibility Signed-off-by: labor00 <[email protected]> * if pytorch version string contains dev return a very big number Signed-off-by: labor00 <[email protected]>
timbore
added a commit
to timbore/horovo
that referenced
this pull request
Sep 28, 2025
…… (#919) * from elementSizeInBytes to element_size, following upstream commit pytorch/pytorch#17785 Signed-off-by: labor00 <[email protected]> * uses TORCH_VERSION macro to ensure backward compatibility Signed-off-by: labor00 <[email protected]> * if pytorch version string contains dev return a very big number Signed-off-by: labor00 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #17785 Remove Type::elementSizeInBytes 💚
Differential Revision: D14379074