TensorLib: a subset of functionality #1766

killeent · 2017-06-09T21:00:55Z

We have done significant development towards creating TensorLib. We would like to move this into PyTorch. Most relevant for the review is the changes made to existing cwrap logic (both processing and the declarations themselves) that were necessary.

This diff creates TensorLib, current state:

TH/THC are bound, basic usage works (not robustly tested)

We don't expect the further work to be done to require changes to cwrap, so we want to get this in now so that we don't further diverge from PyTorch cwrap.

killeent

Some notes for the reader.

torch/lib/TensorLib/ArrayRef.h

torch/lib/TensorLib/CMakeLists.txt

torch/lib/TensorLib/dispatch_macros.py

torch/lib/TensorLib/function_wrapper.py

torch/lib/TensorLib/gen.py

torch/lib/TensorLib/templates/Tensor.h

ezyang · 2017-06-10T03:20:41Z

Cool stuff.

Could the commentary in the PR... perhaps be turned into more permanently durable comments in the source code? :)

ezyang

Still need to carefully review cwrap and C++ templates.

torch/lib/TensorLib/Utils.h

tools/cwrap/plugins/ProcessorSpecificPlugin.py

torch/lib/TensorLib/CPUGenerator.cpp

torch/lib/TensorLib/CUDAGenerator.cpp

torch/lib/TensorLib/Context.h

torch/lib/TensorLib/code_template.py

torch/lib/TensorLib/templates/Tensor.h

torch/csrc/generic/methods/TensorCompare.cwrap

torch/csrc/generic/methods/TensorMath.cwrap

torch/legacy/nn/MarginRankingCriterion.py

torch/lib/TensorLib/ArrayRef.h

torch/lib/TensorLib/CUDAGenerator.cpp

torch/lib/TensorLib/common_with_cwrap.py

torch/lib/TensorLib/templates/GeneratorDerived.h

torch/lib/TensorLib/templates/StorageDerived.cpp

torch/lib/TensorLib/templates/TensorDerived.cpp

torch/lib/TensorLib/templates/Type.h

ezyang · 2017-06-11T01:12:16Z

Yeah, maybe it would be easier to merge just the cwrap stuff if it got separated out into its own PR from the rest of it, which can get bikeshedded and merged later.

apaszke · 2017-06-11T09:45:51Z

@ezyang There are no user-visible changes in this PR, so we don't have to hurry with cwrap commits.

zdevito · 2017-06-12T03:09:59Z

We are trying to get this merged now because there are other in-flight requests like broadcasting and indexing changes that will also impact the cwrap code and are trying to avoid a situation where we are continually fixing merge conflicts while this sits in a separate branch. Tomorrow I'll update the request with a bunch of the changes based on your feedback.

…U,floating_point], [GPU,all]] style pair listings so that we can simplify the logic for elaborating pairs

…+ library yet.

…tPlugin

…ut order for the rest of the library

…nd scalar type are known.

killeent · 2017-06-21T15:06:15Z

Closing in favor of #1865. The code for TensorLib/Aten will be developed in https://github.com/zdevito/aten.

killeent commented Jun 9, 2017

View reviewed changes

killeent changed the title ~~WIP: TensorLib~~ TensorLib: a subset of functionality Jun 9, 2017

ezyang reviewed Jun 10, 2017

View reviewed changes

apaszke reviewed Jun 10, 2017

View reviewed changes

Zachary DeVito and others added 22 commits June 16, 2017 08:20

Initial commit of framework for TensorLib

3e3b767

add storage to generator

d1a81f8

generate cmake outputs using script

4e8d735

adding Type object which will handle dispatch

d9fb931

add tensor skeleton

099987e

put a fake example op in to understand how dispatch will propagate.

d1dc2c8

fix header files to be in TensorLib

eaa5a46

infra to load yaml from cwrap

af4b19a

type, processor annotations in cwrap

682f0bd

add declarations

1eceb47

initial sanitize

7de5e7a

Option elaboration

f3a413e

add sort...

6f3ec49

sanitize names

ef536e1

process types and processors

7df58cd

rename types and processors to match naming in gen.py, allow for [[CP…

3c64d26

…U,floating_point], [GPU,all]] style pair listings so that we can simplify the logic for elaborating pairs

add flags to be able to build without CUDA

f530a4f

add places in templates where we will put generated methods

4f7ba4f

add variants cwrap

37efe77

fix cuda build

3e877d5

backport variant to existing pytorch cwrap

93d90e2

add stuff to process each option in the right place

d32b504

zdevito and others added 9 commits June 16, 2017 09:46

import xt print code, implementing copy and type conversion

a3201ce

fix generator bug, begin porting tests

09307f5

get rid of lt_t variants for now. These will not be exposed in the C+…

d763ec5

…+ library yet.

port xt basic.cpp

2684b9d

reorder build script (lol) so TensorLib will find the nn headers

07a6ebd

move set_declaration_defaults to a common location

06b192d

reuse declaration option sorter from common_with_cwrap in ArgcountSor…

b45df93

…tPlugin

port optional argument declaration handling to shared code

b9604a7

fix some things I screwed up during the rebase

37b0ba2

killeent force-pushed the master branch from 3d33e8b to 37b0ba2 Compare June 16, 2017 17:29

killeent and others added 15 commits June 16, 2017 11:07

remove module references to _t methods

1a742b6

clean up processor specific plugin

23965dd

fix error messages

7880025

make copy copy_out and add copy_ to be consistency with argument/outp…

d8c4038

…ut order for the rest of the library

fix handling of methods that allocate returns

c623111

remove PUBLIC from target_link_libraries in CMake

8ea4d1c

autopep8

5e9b32b

disable tests from cmake for tensorlib

cb61e59

more flake8

7af9216

switch dispatch to function

c9865a8

fix build paths and allow for cwrap_files to be externally specified

9c948a1

add script that can collect all the cwrap declarations for external use

750f669

add accessor object for fast(er) access to tensor data when the dim a…

ad8ab5b

…nd scalar type are known.

add overloaded operators for tensor object

e90a40e

add operator [] to do select

dadf12e

killeent mentioned this pull request Jun 21, 2017

TensorLib/Aten --> changes required in pytorch #1865

Closed

killeent closed this Jun 21, 2017

ezyang added the open source label Jun 24, 2019

TensorLib: a subset of functionality #1766

TensorLib: a subset of functionality #1766

Uh oh!

Conversation

killeent commented Jun 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

killeent left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

ezyang commented Jun 10, 2017

Uh oh!

ezyang left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

killeent commented Jun 9, 2017 •

edited

Loading

zdevito commented Jun 12, 2017 •

edited

Loading