Skip to content

Conversation

@bhushan23
Copy link
Contributor

  • Test cases added
  1. indexing for half tensor
  2. setting for half tensor

fixes #17161

- Test cases added
1. indexing for half tensor
2. setting for half tensor
Copy link
Collaborator

@ssnl ssnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssnl
Copy link
Collaborator

ssnl commented Mar 4, 2019

@pytorchbot merge this please

@pytorchbot pytorchbot added the merge-this-please Was marked for merge with @pytorchbot merge this please label Mar 4, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@bhushan23 bhushan23 deleted the index-half branch March 6, 2019 18:37
zdevito pushed a commit to zdevito/ATen that referenced this pull request Mar 6, 2019
Summary:
- Test cases added
1. indexing for half tensor
2. setting for half tensor

fixes #17161
Pull Request resolved: pytorch/pytorch#17645

Differential Revision: D14302069

Pulled By: ezyang

fbshipit-source-id: 100f141c07046f200c904e27c5882a9417bccda0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-this-please Was marked for merge with @pytorchbot merge this please open source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

index operation is not supported in torch.HalfTensor

5 participants