Skip to content

Small clean up of aten_op #17530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
li-roy wants to merge 45 commits into from
Closed

Small clean up of aten_op #17530

li-roy wants to merge 45 commits into from

Conversation

@li-roy
Copy link
Contributor

@li-roy li-roy commented Feb 27, 2019 •
edited
Loading

Stack:
    :black_circle:  #17530 Small clean up of aten_op  💚
    :white_circle:  #17601 Store ScalarType and Backend instead of Type in TensorIterator  💚
    :white_circle:  #17785 Remove Type::elementSizeInBytes  💚
    :white_circle:  #17723 Store python default type as PyTensorType instead of at::Type  💚
    :white_circle:  #17786 Pass ScalarType separately from Type in python constructors  💚
    :white_circle:  #17792 Remove Type::ScalarType()  💚
    :white_circle:  #17603 Remove conversion operator from Type to TensorOptions  💛
    :white_circle:  #17787 Add ScalarType arg to Type::options()  💛

Differential Revision: D14237931

royboy added 5 commits February 26, 2019 14:15
V1: Initial commit
029ba61 
Differential Revision: D14233250
Differential Version: 73474786
V2: (no description)
c789040 
Differential Revision: D14233250
Differential Version: 73486177
V1: Initial commit
aa6f43d 
Differential Revision: D14235395
Differential Version: 73486176
V1: Initial commit
04b5fcb 
Differential Revision: D14237932
Differential Version: 73508674
V1: Initial commit
56974d0 
Differential Revision: D14237931
Differential Version: 73508673
This was referenced Feb 27, 2019
Closed
Closed
Closed
royboy added 7 commits February 27, 2019 10:24
V2: (no description)
df84312 
Differential Revision: D14235395
Differential Version: 73589963
V2: Merge with parent diff changes
6edc915 
Differential Revision: D14237932
Differential Version: 73589962
V2: Merge with parent diff changes
38b7350 
Differential Revision: D14237931
Differential Version: 73589961
V3: (no description)
9f277a5 
Differential Revision: D14237932
Differential Version: 73659349
V3: Merge with parent diff changes
149b79c 
Differential Revision: D14237931
Differential Version: 73659351
V4: (no description)
78a705e 
Differential Revision: D14237932
Differential Version: 73714105
V4: Merge with parent diff changes
0bf2cd7 
Differential Revision: D14237931
Differential Version: 73714104
This was referenced Mar 1, 2019
Closed
Closed
@li-roy li-roy requested a review from gchanan March 1, 2019 23:21
@gchanan
Copy link
Contributor

gchanan commented Mar 1, 2019

is the test failure legit?

@gchanan
Copy link
Contributor

gchanan commented Mar 1, 2019

mind showing the generated code differences?

royboy added 7 commits March 5, 2019 19:12
V3: Merge with parent diff changes
8634053 
Differential Revision: D14235395
Differential Version: 74395307
V3: Merge with parent diff changes
88179bc 
Differential Revision: D14233250
Differential Version: 74395306
V5: Merge with parent diff changes
0fd6402 
Differential Revision: D14237932
Differential Version: 74395305
V5: Merge with parent diff changes
6caec37 
Differential Revision: D14237931
Differential Version: 74395302
V4: (no description)
65f6158 
Differential Revision: D14235395
Differential Version: 74488005
V6: Merge with parent diff changes
e0804b9 
Differential Revision: D14237932
Differential Version: 74488004
V6: Merge with parent diff changes
cc3cc5e 
Differential Revision: D14237931
Differential Version: 74488002
@li-roy li-roy mentioned this pull request Mar 6, 2019
Closed
@li-roy
Copy link
Contributor Author

li-roy commented Mar 7, 2019

current test failures don't seem to be related.

@li-roy
Copy link
Contributor Author

li-roy commented Mar 7, 2019

really the only change in gen_aten_op.h are changes like these:

before:

      case 832: { // item
      
          run_op = [=] {
              auto self = peek(0, 1);
              auto inferred_type = &at::getType(self);
              auto the_result = self.item();
              assignTo(Output(0),*inferred_type, the_result);
              return true;
          };

after:

      case 832: { // item
      
          run_op = [=] {
              auto self = peek(0, 1);
              auto the_result = self.item();
              assignTo(Output(0),self.scalar_type(), the_result);
              return true;
          };
      } break;

full changes if you want to see them:
old: https://gist.github.com/li-roy/0f35ffa897dca7b11393980aa5bee668
new: https://gist.github.com/li-roy/7c832921df37197784fbca2b12360a34

royboy added 4 commits March 7, 2019 16:27
V5: Merge with parent diff changes
c536d29 
Differential Revision: D14233250
Differential Version: 74694645
V6: Merge with parent diff changes
0ad5534 
Differential Revision: D14235395
Differential Version: 74694653
V8: Merge with parent diff changes
f82c26c 
Differential Revision: D14237932
Differential Version: 74694651
V8: Merge with parent diff changes
078201a 
Differential Revision: D14237931
Differential Version: 74694648
This was referenced Mar 8, 2019
Closed
Closed
Closed
royboy added 6 commits March 7, 2019 18:19
V7: (no description)
0c329b5 
Differential Revision: D14235395
Differential Version: 74711130
V9: Merge with parent diff changes
6cdd649 
Differential Revision: D14237932
Differential Version: 74711134
V9: Merge with parent diff changes
e05681f 
Differential Revision: D14237931
Differential Version: 74711129
V8: (no description)
1f2c6b6 
Differential Revision: D14235395
Differential Version: 74714416
V10: Merge with parent diff changes
e50a8e5 
Differential Revision: D14237932
Differential Version: 74714419
V10: Merge with parent diff changes
a6cb051 
Differential Revision: D14237931
Differential Version: 74714408
@li-roy li-roy mentioned this pull request Mar 8, 2019
Closed
royboy added 11 commits March 8, 2019 13:10
V6: Merge with parent diff changes
4fe3ca5 
Differential Revision: D14233250
Differential Version: 74781242
V9: Merge with parent diff changes
37f1cdc 
Differential Revision: D14235395
Differential Version: 74781247
V11: Merge with parent diff changes
12b478a 
Differential Revision: D14237932
Differential Version: 74781246
V11: Merge with parent diff changes
6730846 
Differential Revision: D14237931
Differential Version: 74781238
V10: (no description)
8b00594 
Differential Revision: D14235395
Differential Version: 74811455
V12: Merge with parent diff changes
8871f32 
Differential Revision: D14237932
Differential Version: 74811463
V12: Merge with parent diff changes
0884e3d 
Differential Revision: D14237931
Differential Version: 74811456
V11: Merge with parent diff changes
9810bf6 
Differential Revision: D14235395
Differential Version: 74818459
V13: Merge with parent diff changes
ec929c0 
Differential Revision: D14237932
Differential Version: 74818452
V13: Merge with parent diff changes
ab2ef02 
Differential Revision: D14237931
Differential Version: 74818453
V14: Merge with parent diff changes
6dd3d84 
Differential Revision: D14237931
Differential Version: 74843005
@li-roy li-roy changed the base branch from export-D14237932 to master March 9, 2019 00:57
V15: Merge with parent diff changes
a5bc6af 
Differential Revision: D14237931
Differential Version: 74983509
@ezyang ezyang deleted the export-D14237931 branch May 30, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gchanan gchanan gchanan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@li-roy @gchanan @pytorchbot