Skip to content

Fix SelectionFunction double backwards by not unwrapping grad_output … #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soumith merged 1 commit into from
Jun 7, 2017
Merged

Fix SelectionFunction double backwards by not unwrapping grad_output … #1753

soumith merged 1 commit into from
Jun 7, 2017

Conversation

@gchanan
Copy link
Contributor

@gchanan gchanan commented Jun 7, 2017

…data.

@gchanan
Copy link
Contributor Author

gchanan commented Jun 7, 2017

Fixes #1712.

I verified this using gradgradcheck from #1643 -- it fails without this change and passes with it.

@soumith soumith merged commit 11e7a7d into pytorch:master Jun 7, 2017
apaszke
apaszke reviewed Jun 7, 2017
View reviewed changes
torch/autograd/_functions/reduce.py
grad_input = Variable(grad_output.data.new(*ctx.input_size).zero_())
if ctx.dim is None and cls.has_all_reduce:
grad_input[ctx.indices_tuple] = grad_output.data[0]
grad_input[ctx.indices_tuple] = grad_output[0]

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@gchanan gchanan mentioned this pull request Jun 8, 2017
Merged
facebook-github-bot pushed a commit that referenced this pull request Jan 22, 2019
@houseroad @facebook-github-bot
Automatic update of fbcode/onnx to dc75285d4a1cff9618400164dfdb26c5a1…
e7a77ac 
…bab70a

Summary:
Previous import was c553fb32a0902ce5dd42e1b40123e9e9b38bdbe7

Included changes:
- **[dc75285](onnx/onnx@dc75285)**: Relax constraint that the initializers must be a subset of graph inputs (#1718) <G. Ramalingam>
- **[985c8cd](onnx/onnx@985c8cd)**: Fix typo in scan shape inferencing (#1753) <Scott McKay>
- **[ab52a5d](onnx/onnx@ab52a5d)**: remove stale test cases <Lu Fang>
- **[56434bb](onnx/onnx@56434bb)**: Removing experimental ConstantFill op. <Spandan Tiwari>
- **[881c63c](onnx/onnx@881c63c)**: Show string names of data types instead of int IDs (#1749) <Shinichiro Hamaji>
- **[0a12fe4](onnx/onnx@0a12fe4)**: Update ConstantOfShape op. (#1744) <Bowen Bao>
- **[ef028e5](onnx/onnx@ef028e5)**: Update definition of Cast Op to support casting to/from string (#1704) <Raymond Yang>

Reviewed By: BIT-silence

Differential Revision: D13773962

fbshipit-source-id: b98079277994a699d4807210ba1d9c27f4672090
jjsjann123 pushed a commit to jjsjann123/pytorch that referenced this pull request Jun 7, 2022
@naoyam
Fix issue pytorch#1751 (pytorch#1753)
02a05d9 
Also add a test that concretizes a symbolic domain. The concrete size
is not picked up at the generated code, which should be addressed as a
separate PR.
jjsjann123 added a commit to jjsjann123/pytorch that referenced this pull request Jun 8, 2022
@jjsjann123
Syncing nvfuser devel branch to upstream master. https://github.com/c…
c2b1241 
…sarofeen/pytorch/

Squashed commits to WAR github API

Commits that's actually in this PR from the devel branch:

4c60e7d Add examples infrastructure for using nvFuser in a standalone program (pytorch#1725)
02a05d9 Fix issue pytorch#1751 (pytorch#1753)
8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (pytorch#1746)
ffdf6b7 Remove BroadcastWithoutStride. (pytorch#1738)
02bab16 Fix flipping of a boolean flag (pytorch#1745)
465d668 cleanup (pytorch#1744)
26d354e fixing noncontig broadcast (pytorch#1742)
856b6b2 Add IterDomainBuilder (pytorch#1736)
1fd974f fixing warning for gcc7 (pytorch#1732)
de2740a disabling complex in python tests for pytorch#1730 (pytorch#1733)
fbbbe0a fixing MSVC build (pytorch#1728)
b5feee5 Fix the fused reduction runtime kernel (pytorch#1729)
5247682 Re-entrant GroupedGridReduction (pytorch#1727)
pytorchmergebot pushed a commit that referenced this pull request Jun 10, 2022
@jjsjann123 @pytorchmergebot
[nvfuser_upstream_push] nvfuser code base bump 060822 (#79147)
49c41b8 
Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/

Bug fixes and minor refactor

Squashed commits to WAR github API
Commits that's actually in this PR from the devel branch:

```
4c60e7d Add examples infrastructure for using nvFuser in a standalone program (#1725)
02a05d9 Fix issue #1751 (#1753)
8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (#1746)
ffdf6b7 Remove BroadcastWithoutStride. (#1738)
02bab16 Fix flipping of a boolean flag (#1745)
465d668 cleanup (#1744)
26d354e fixing noncontig broadcast (#1742)
856b6b2 Add IterDomainBuilder (#1736)
1fd974f fixing warning for gcc7 (#1732)
de2740a disabling complex in python tests for #1730 (#1733)
fbbbe0a fixing MSVC build (#1728)
b5feee5 Fix the fused reduction runtime kernel (#1729)
5247682 Re-entrant GroupedGridReduction (#1727)
```

RUN_TORCHBENCH: nvfuser
Pull Request resolved: #79147
Approved by: https://github.com/davidberard98
facebook-github-bot pushed a commit that referenced this pull request Jun 10, 2022
@jjsjann123 @facebook-github-bot
[nvfuser_upstream_push] nvfuser code base bump 060822 (#79147)
5109e0d 
Summary:
Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/

Bug fixes and minor refactor

Squashed commits to WAR github API
Commits that's actually in this PR from the devel branch:

```
4c60e7d Add examples infrastructure for using nvFuser in a standalone program (#1725)
02a05d9 Fix issue #1751 (#1753)
8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (#1746)
ffdf6b7 Remove BroadcastWithoutStride. (#1738)
02bab16 Fix flipping of a boolean flag (#1745)
465d668 cleanup (#1744)
26d354e fixing noncontig broadcast (#1742)
856b6b2 Add IterDomainBuilder (#1736)
1fd974f fixing warning for gcc7 (#1732)
de2740a disabling complex in python tests for #1730 (#1733)
fbbbe0a fixing MSVC build (#1728)
b5feee5 Fix the fused reduction runtime kernel (#1729)
5247682 Re-entrant GroupedGridReduction (#1727)
```

Pull Request resolved: #79147

Reviewed By: zou3519

Differential Revision: D37038192

Pulled By: davidberard98

fbshipit-source-id: 330f46ee21eef5c2de7e178290f2962aa030393e
pytorchmergebot pushed a commit that referenced this pull request Jun 16, 2022
@jjsjann123 @pytorchmergebot
[nvfuser_upstream_push] Reland: nvfuser code base bump 060822 (#79406)
c9c402e 
Landing reverted PR #79147.

Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/

Bug fixes and minor refactor

Squashed commits to WAR github API
Commits that's actually in this PR from the devel branch:

```
4c60e7d Add examples infrastructure for using nvFuser in a standalone program (#1725)
02a05d9 Fix issue #1751 (#1753)
8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (#1746)
ffdf6b7 Remove BroadcastWithoutStride. (#1738)
02bab16 Fix flipping of a boolean flag (#1745)
465d668 cleanup (#1744)
26d354e fixing noncontig broadcast (#1742)
856b6b2 Add IterDomainBuilder (#1736)
1fd974f fixing warning for gcc7 (#1732)
de2740a disabling complex in python tests for #1730 (#1733)
fbbbe0a fixing MSVC build (#1728)
b5feee5 Fix the fused reduction runtime kernel (#1729)
5247682 Re-entrant GroupedGridReduction (#1727)
```

RUN_TORCHBENCH: nvfuser
Pull Request resolved: #79406
Approved by: https://github.com/davidberard98
facebook-github-bot pushed a commit that referenced this pull request Jun 16, 2022
@jjsjann123 @facebook-github-bot
[nvfuser_upstream_push] Reland: nvfuser code base bump 060822 (#79406)
f384845 
Summary:
Landing reverted PR #79147.

Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/

Bug fixes and minor refactor

Squashed commits to WAR github API
Commits that's actually in this PR from the devel branch:

```
4c60e7d Add examples infrastructure for using nvFuser in a standalone program (#1725)
02a05d9 Fix issue #1751 (#1753)
8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (#1746)
ffdf6b7 Remove BroadcastWithoutStride. (#1738)
02bab16 Fix flipping of a boolean flag (#1745)
465d668 cleanup (#1744)
26d354e fixing noncontig broadcast (#1742)
856b6b2 Add IterDomainBuilder (#1736)
1fd974f fixing warning for gcc7 (#1732)
de2740a disabling complex in python tests for #1730 (#1733)
fbbbe0a fixing MSVC build (#1728)
b5feee5 Fix the fused reduction runtime kernel (#1729)
5247682 Re-entrant GroupedGridReduction (#1727)
```

RUN_TORCHBENCH: nvfuser

Pull Request resolved: #79406

Reviewed By: anjali411

Differential Revision: D37109147

Pulled By: davidberard98

fbshipit-source-id: 14209be028a3338be112cc83ffe77e631f802891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@apaszke apaszke apaszke left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gchanan @apaszke @soumith