Remove some simple use cases of Type::ScalarType() #17529
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D14237932 Differential Version: 73508674
This was referenced Feb 27, 2019
added 3 commits
February 27, 2019 10:24
Differential Revision: D14237932 Differential Version: 73589962
Differential Revision: D14237932 Differential Version: 73659349
Differential Revision: D14237932 Differential Version: 73714105
This was referenced Mar 1, 2019
added 2 commits
March 5, 2019 19:12
Differential Revision: D14237932 Differential Version: 74395305
Differential Revision: D14237932 Differential Version: 74488004
added 2 commits
March 6, 2019 16:33
Differential Revision: D14237932 Differential Version: 74537073
Differential Revision: D14237932 Differential Version: 74694651
This was referenced Mar 8, 2019
added 2 commits
March 7, 2019 18:19
Differential Revision: D14237932 Differential Version: 74711134
Differential Revision: D14237932 Differential Version: 74714419
added 3 commits
March 8, 2019 13:10
Differential Revision: D14237932 Differential Version: 74781246
Differential Revision: D14237932 Differential Version: 74811463
Differential Revision: D14237932 Differential Version: 74818452
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Mar 9, 2019
Summary: Pull Request resolved: pytorch/pytorch#17529 Reviewed By: ezyang Differential Revision: D14237932 fbshipit-source-id: be633a1fc19215d53cfe083fdd7196acf2b7dd2f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #17527 Change Dispatch.h to use ScalarType over Type 💚
:black_circle: #17529 Remove some simple use cases of Type::ScalarType() 💚
:white_circle: #17530 Small clean up of aten_op 💚
:white_circle: #17601 Store ScalarType and Backend instead of Type in TensorIterator 💚
:white_circle: #17785 Remove Type::elementSizeInBytes 💚
:white_circle: #17723 Store python default type as PyTensorType instead of at::Type 💚
:white_circle: #17786 Pass ScalarType separately from Type in python constructors 💚
:white_circle: #17792 Remove Type::ScalarType() 💚
:white_circle: #17603 Remove conversion operator from Type to TensorOptions 💛
:white_circle: #17787 Add ScalarType arg to Type::options() 💛
Differential Revision: D14237932