Add support for NVTX functions. #1748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaszke
suggested changes
Jun 7, 2017
Contributor
apaszke
left a comment
apaszke
left a comment
There was a problem hiding this comment.
I'd be nice to add support for colors too. Should be easy to do
setup.py
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
colesbury
reviewed
Jun 7, 2017
torch/cuda/nvtx.py
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
colesbury
reviewed
Jun 7, 2017
Member
colesbury
left a comment
colesbury
left a comment
There was a problem hiding this comment.
A simple test would be good so at least we can check that the library is loaded correctly.
torch/cuda/nvtx.py
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
colesbury
reviewed
Jun 7, 2017
torch/cuda/nvtx.py
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
|
This looks good, just fix the lint and the Python 3 contbuild |
This commit adds support for the simple, ASCII message only
NVTX functions. There are a few more but these are the ones
I'm mostly interested in.
I tested by running this script under nvprof:
import torch.cuda.nvtx
torch.cuda.nvtx.range_push("foo")
torch.cuda.nvtx.mark("bar")
torch.cuda.nvtx.range_pop()
And verifying that the events showed up.
NB: An earlier version of this patch lazily loaded libNvExtTools.so.
At the prompting of @colesbury, we decided against this, because
dynamically loading the library means we can get into bad
situations where we load the wrong version of the library. If we
do it at build time, this situation won't occur.
Signed-off-by: Edward Z. Yang <[email protected]>
- Remove redundant imports from torch.cuda.nvtx - Import torch.cuda.nvtx from torch.cuda, so it becomes available when you import torch.cuda - Add a small, trivial test to test_cuda.py Signed-off-by: Edward Z. Yang <[email protected]>
Signed-off-by: Edward Z. Yang <[email protected]>
Signed-off-by: Edward Z. Yang <[email protected]>
Contributor
Author
|
All good! |
apaszke
reviewed
Jun 10, 2017
| global lib | ||
| if lib is None: | ||
| lib = ctypes.cdll.LoadLibrary(None) | ||
| lib.nvtxMarkA.restype = None |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
houseroad
added a commit
to houseroad/pytorch
that referenced
this pull request
Jan 19, 2019
…8bdbe7 Summary: Previous import was fd60104394fa353e1762f44ecad1b2166e33deef Included changes: - **[c553fb3](onnx/onnx@c553fb3)**: Handle negative axis in scan shape inference (pytorch#1748) <G. Ramalingam> - **[51b6ecc](onnx/onnx@51b6ecc)**: external_data: Store large tensor values in separate files (pytorch#678) <Michał Karzyński> - **[ba05f26](onnx/onnx@ba05f26)**: Scan output axes (pytorch#1737) <G. Ramalingam> - **[90920c0](onnx/onnx@90920c0)**: Add NonZero op. (pytorch#1714) <Sergii Dymchenko> - **[c4cf112](onnx/onnx@c4cf112)**: fix the test cases for constantofshape (pytorch#1746) <Lu Fang> - **[d902349](onnx/onnx@d902349)**: Add sample implementation support (pytorch#1712) <Lu Fang> Differential Revision: D13745693 fbshipit-source-id: 057d827652e85ad19be8f0243d874e036bf69898
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 21, 2019
…8bdbe7 (#16190) Summary: Pull Request resolved: #16190 Previous import was fd60104394fa353e1762f44ecad1b2166e33deef Included changes: - **[c553fb3](onnx/onnx@c553fb3)**: Handle negative axis in scan shape inference (#1748) <G. Ramalingam> - **[51b6ecc](onnx/onnx@51b6ecc)**: external_data: Store large tensor values in separate files (#678) <Michał Karzyński> - **[ba05f26](onnx/onnx@ba05f26)**: Scan output axes (#1737) <G. Ramalingam> - **[90920c0](onnx/onnx@90920c0)**: Add NonZero op. (#1714) <Sergii Dymchenko> - **[c4cf112](onnx/onnx@c4cf112)**: fix the test cases for constantofshape (#1746) <Lu Fang> - **[d902349](onnx/onnx@d902349)**: Add sample implementation support (#1712) <Lu Fang> Differential Revision: D13745693 fbshipit-source-id: 05e2cce9ae1dfa2865db83840df64673d55cea57
akashveramd
pushed a commit
to akashveramd/pytorch
that referenced
this pull request
Apr 9, 2025
* upgrade sqlalchemy version * replace the connection with engine in to_sql call * change the hipTes=nsor ctest syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for the simple, ASCII message only
NVTX functions. There are a few more but these are the ones
I'm mostly interested in.
I tested by running this script under nvprof:
And verifying that the events showed up.
Signed-off-by: Edward Z. Yang [email protected]