ONNX Export Argmin and Argmax ops #17382
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houseroad
requested changes
Feb 27, 2019
Member
houseroad
left a comment
houseroad
left a comment
There was a problem hiding this comment.
I think the failed CI is caused by the infra error. Please rebase to master since we already bump up the onnx version and producer version.
lara-hdr
requested review from
ebetica,
goldsborough and
yf225
as code owners
lara-hdr
force-pushed
the
lahaidar/onnx_export_argmax
branch
from
64b29ac to
3b467f7
Compare
Contributor
Author
|
@houseroad is the pr/py2-devtoolset7-rocmrpm-centos7.5 failure something I should invest time in investigating? |
Member
|
@lara-hdr no, I think it's infra error. I have restarted it. |
Contributor
Author
|
@houseroad would it be possible to merge this if there are no other comments? |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.