[jit] add clear functionality to list #17050
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
driazati
approved these changes
Feb 13, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
eellison
reviewed
Feb 14, 2019
| pop(stack, a); | ||
|
|
||
| a->elements().clear(); | ||
| push(stack, a); |
Contributor
There was a problem hiding this comment.
This shouldn't be pushing to the stack
zou3519
added a commit
to zou3519/pytorch
that referenced
this pull request
Mar 12, 2019
Summary: Add clear functionality to list. See pytorch#16662 ```python import torch torch.jit.script def foo(): a = [1, 2, 3, 4] a.clear() return a ``` Pull Request resolved: pytorch#17050 Differential Revision: D14071799 Pulled By: driazati fbshipit-source-id: 305551c16f7db127c43de0ad5885d9f10678e101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add clear functionality to list. See #16662