Fix gc_refs assertion failure #1705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that each THPVariable -> THPFunction reference contributes one ref count to the THPFunction by creating a new shared_ptr for each ref. Because multiple shared_ptrs can again manage a single THPFunction, it's not safe to use std::weak_ptr where it may point to a PyFunction. It's still safe to use weak_ptr for grad_accumulator since these are never PyFunctions. Fixes pytorch#1626
apaszke
reviewed
Jun 2, 2017
| // The C++ wrapper for this Python function. | ||
| // See a comment in THPFunction_asFunction for details about this field. | ||
| // You can use cdata directly if you don't actually need a shared_ptr. | ||
| std::weak_ptr<torch::autograd::PyFunction> cdata_ptr; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| int expected_version; | ||
|
|
||
| std::shared_ptr<Variable> unpack(); | ||
| std::shared_ptr<Variable> unpack(std::shared_ptr<Function> saved_for=nullptr); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
soumith
approved these changes
Jun 3, 2017
jjsjann123
pushed a commit
to jjsjann123/pytorch
that referenced
this pull request
May 17, 2022
* Fix un-welford transformation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that each THPVariable -> THPFunction reference contributes one
ref count to the THPFunction by creating a new shared_ptr for each ref.
Because multiple shared_ptrs can again manage a single THPFunction, it's
not safe to use std::weak_ptr where it may point to a PyFunction. It's
still safe to use weak_ptr for grad_accumulator since these are never
PyFunctions.
Fixes #1626