[aarch64][caffe2] Fix FBGEMM detection on aarch64#169379
[aarch64][caffe2] Fix FBGEMM detection on aarch64#169379andrewjcg wants to merge 7 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/169379
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 1fe48df with merge base afb173d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@andrewjcg has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88096853. |
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
IMO this is a misleading statement and will lead to compilation errors on RiscV, PowerPC, S390 hardware. Also, PyTorch is not really supported on 32-bit OSes, so one can just remove this check completely
CMakeLists.txt
Outdated
| if(USE_FBGEMM AND NOT CMAKE_SYSTEM_PROCESSOR MATCHES "^(x86_64|aarch64)$") | ||
| message(WARNING | ||
| "x64 operating system is required for FBGEMM. " | ||
| "64-bit operating system is required for FBGEMM. " |
There was a problem hiding this comment.
This is a wrong statement. This will not work on RISCV or S390, will it? If one really wants to check for 64-bit OS, they need to modify the condition to CMAKE_SIZEOF_VOID_P EQUALS 8
There was a problem hiding this comment.
Updated -- does this seem good?
There was a problem hiding this comment.
Looks good to me, thank you for the update
andrewjcg
force-pushed
the
export-D88096853
branch
from
a17cb3b to
b290581
Compare
Summary: Update as per-comment: FBGEMM works on aarch64, just not on x86_32. Test Plan: CI Differential Revision: D88096853
@malfet Does this mean that we can just remove |
|
The aarch64 build failure looks related https://github.com/pytorch/pytorch/actions/runs/19908456569/job/57070803485 also I have no idea yet how setting |
Signed-off-by: Huy Do <[email protected]>
|
@pytorchbot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
|
Successfully rebased |
pytorchmergebot
force-pushed
the
export-D88096853
branch
from
b290581 to
0af97b0
Compare
Summary: Update as per-comment: FBGEMM works on aarch64, just not on x86_32. Test Plan: CI Differential Revision: D88096853
|
@pytorchbot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
|
Successfully rebased |
pytorchmergebot
force-pushed
the
export-D88096853
branch
from
0af97b0 to
1ab590f
Compare
Summary: Update as per-comment: FBGEMM works on aarch64, just not on x86_32. Test Plan: CI Differential Revision: D88096853
|
@pytorchbot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
Summary: Update as per-comment: FBGEMM works on aarch64, just not on x86_32. Test Plan: CI Differential Revision: D88096853
|
Successfully rebased |
pytorchmergebot
force-pushed
the
export-D88096853
branch
from
1ab590f to
997b957
Compare
huydhn
removed request for
digantdesai,
jerryzh168,
kimishpatel and
salilsdesai
huydhn
removed
ciflow/h100
ciflow/b200
release notes: quantization
|
With pytorch/FBGEMM#5207 landed, this should work now across all platforms |
|
Not sure, it enables more platforms. |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
|
This PR updates submodules third_party/fbgemm If those updates are intentional, please add "submodule" keyword to PR title/description. |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 0 checks: Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot merge -f "Pending H100, but aarch64 CI is green" |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: Update as per-comment: FBGEMM works on aarch64, just not on x86_32. Test Plan: CI Differential Revision: D88096853 submodule Pull Request resolved: pytorch#169379 Approved by: https://github.com/malfet Co-authored-by: Huy Do <[email protected]>
Summary: Update as per-comment: FBGEMM works on aarch64, just not on x86_32. Test Plan: CI Differential Revision: D88096853 submodule Pull Request resolved: pytorch#169379 Approved by: https://github.com/malfet Co-authored-by: Huy Do <[email protected]>
7 participants
Summary: Update as per-comment: FBGEMM works on aarch64, just not on x86_32.
Test Plan: CI
Differential Revision: D88096853
submodule
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168 @aditew01