-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[tests] Align SDPA tests with cuDNN versions #169321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add missing cuDNN version checks to align test expectations with C++ implementation requirements: - test_cudnn_attention_d256_heuristic: Check >= 9.10.0 for head_dim=256 - test_fused_sdp_choice: Check >= 9.9.0 for backend prioritization Also updated outdated TODO from pytorch#138522.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/169321
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 351f315 with merge base ded9bcd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
eqy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Add missing cuDNN version checks to align test expectations with C++ implementation requirements: - test_cudnn_attention_d256_heuristic: Check >= 9.10.0 for head_dim=256 - test_fused_sdp_choice: Check >= 9.9.0 for backend prioritization - Also updated outdated TODO from pytorch#138522. I ran into these failing tests in test_transformers.py when using an older cuDNN version (9.6.0). Pull Request resolved: pytorch#169321 Approved by: https://github.com/eqy
Add missing cuDNN version checks to align test expectations with C++ implementation requirements: - test_cudnn_attention_d256_heuristic: Check >= 9.10.0 for head_dim=256 - test_fused_sdp_choice: Check >= 9.9.0 for backend prioritization - Also updated outdated TODO from pytorch#138522. I ran into these failing tests in test_transformers.py when using an older cuDNN version (9.6.0). Pull Request resolved: pytorch#169321 Approved by: https://github.com/eqy
Add missing cuDNN version checks to align test expectations with C++ implementation requirements:
I ran into these failing tests in test_transformers.py when using an older cuDNN version (9.6.0).
cc @ptrblck @msaroufim @eqy @jerryzh168 @tinglvv @nWEIdia @mruberry