Skip to content

Conversation

@stmcgovern
Copy link
Collaborator

@stmcgovern stmcgovern commented Dec 1, 2025

Add missing cuDNN version checks to align test expectations with C++ implementation requirements:

I ran into these failing tests in test_transformers.py when using an older cuDNN version (9.6.0).

cc @ptrblck @msaroufim @eqy @jerryzh168 @tinglvv @nWEIdia @mruberry

Add missing cuDNN version checks to align test expectations with
C++ implementation requirements:
- test_cudnn_attention_d256_heuristic: Check >= 9.10.0 for head_dim=256
- test_fused_sdp_choice: Check >= 9.9.0 for backend prioritization
Also updated outdated TODO from pytorch#138522.
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/169321

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 351f315 with merge base ded9bcd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 1, 2025
@jbschlosser jbschlosser requested a review from drisspg December 9, 2025 19:32
@jbschlosser jbschlosser added module: tests Issues related to tests (not the torch.testing module) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: sdpa All things related to torch.nn.functional.scaled_dot_product_attentiion labels Dec 9, 2025
@drisspg drisspg requested a review from eqy December 9, 2025 21:45
@drisspg drisspg added the module: cuda Related to torch.cuda, and CUDA support in general label Dec 9, 2025
Copy link
Collaborator

@eqy eqy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 9, 2025

To add the ciflow label ciflow/b200 please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 9, 2025

To add the ciflow label ciflow/h100 please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@stmcgovern
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 10, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@stmcgovern
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

skpark-rh pushed a commit to skpark-rh/pytorch that referenced this pull request Dec 10, 2025
Add missing cuDNN version checks to align test expectations with C++ implementation requirements:
- test_cudnn_attention_d256_heuristic: Check >= 9.10.0 for head_dim=256
- test_fused_sdp_choice: Check >= 9.9.0 for backend prioritization
-  Also updated outdated TODO from pytorch#138522.

I ran into these failing tests in test_transformers.py when using an older cuDNN version (9.6.0).

Pull Request resolved: pytorch#169321
Approved by: https://github.com/eqy
daisyden pushed a commit to daisyden/pytorch that referenced this pull request Dec 11, 2025
Add missing cuDNN version checks to align test expectations with C++ implementation requirements:
- test_cudnn_attention_d256_heuristic: Check >= 9.10.0 for head_dim=256
- test_fused_sdp_choice: Check >= 9.9.0 for backend prioritization
-  Also updated outdated TODO from pytorch#138522.

I ran into these failing tests in test_transformers.py when using an older cuDNN version (9.6.0).

Pull Request resolved: pytorch#169321
Approved by: https://github.com/eqy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: cuda Related to torch.cuda, and CUDA support in general module: sdpa All things related to torch.nn.functional.scaled_dot_product_attentiion module: tests Issues related to tests (not the torch.testing module) open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants