Add suggest add to __constants__ message on save fail #16850
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
driazati
reviewed
Feb 7, 2019
| throw script::ErrorReport(node->getSourceLocation()) | ||
| << "could not export python function call " << value->name() | ||
| << ". Remove calls to Python functions before export"; | ||
| << ". Remove calls to Python functions before export (did you forget to add it to __constants__?)"; |
Contributor
There was a problem hiding this comment.
There should be some filtering here, if this printed when people include a Python function in their model and then export, this suggests adding it to __constants__ will fix it
Contributor
Author
There was a problem hiding this comment.
I'm not sure how to filter that here
driazati
approved these changes
Feb 8, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@eellison is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.