[cudnn rnn fp32 math accumulation] #16825
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating persistent rnn check with input data type Updating rnn type promotion to enable set correct math type replace datatype check for filter descriptor from rnn.datatype to input.datatype
soumith
reviewed
Feb 7, 2019
Collaborator
Author
|
Ping @ngimel for visibility |
…lows TensorCore to be used with fp32 accumulation; 2. add comment for disabling type promotion in cudnn 7.1.3
Collaborator
Author
|
@pytorchbot retest this please |
Contributor
|
I guess we're gonna need a cudnn 3.5 build soon... |
Closed
ezyang
approved these changes
Feb 13, 2019
Contributor
|
@ngimel let me know if you want to review this before we put it in! |
ngimel
approved these changes
Feb 13, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Feb 15, 2019
Summary: setting the correct math type for cudnn rnn, which is enforced starting from cudnn 7.5+ 1. Updating persistent rnn check with input data type instead of rnn math type; 2. Updating rnn type promotion to set correct math type for accumulation; 3. Replace datatype check for filter descriptor from rnn.datatype to input.datatype; Pull Request resolved: pytorch/pytorch#16825 Differential Revision: D14071190 Pulled By: ezyang fbshipit-source-id: 1c9a1531ccf510cb0619e830be444c20c5e72f3f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: setting the correct math type for cudnn rnn, which is enforced starting from cudnn 7.5+