[dynamo, nested graph breaks] fix FOR_ITER iterator push and zip strict; enable nested graph break tests on test_functions.py #167694
Conversation
…ct; enable nested graph break tests on test_functions.py [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167694
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 2 Unrelated FailuresAs of commit 7fc52bb with merge base 86f9a9a ( CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
The label |
|
The label |
|
The label |
|
The label |
…nd zip strict; enable nested graph break tests on test_functions.py" cc mlazos voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
|
The label |
…ct; enable nested graph break tests on test_functions.py ghstack-source-id: a9799d9 Pull Request resolved: pytorch/pytorch#167694
…nd zip strict; enable nested graph break tests on test_functions.py" cc mlazos voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
williamwen42
added
the
ciflow/dynamo
…nd zip strict; enable nested graph break tests on test_functions.py" The iterator push in FOR_ITER must be done before attempting to call next_variable because if next_variable graph breaks with nested graph breaks on, the iterator must be on the stack to resume properly. cc mlazos voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
| return variables.ZipVariable( | ||
| iter_args, | ||
| strict=strict, # type: ignore[arg-type] | ||
| strict=strict.as_python_constant(), |
There was a problem hiding this comment.
So we were passing in a VariableTracker before and now we want a real python constant?
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: dynamo-unittest / dynamo-test (3.12) / test (dynamo_wrapped, 3, 3, linux.c7i.2xlarge) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 3 checks: dynamo-unittest / dynamo-test (3.11) / test (dynamo_wrapped, 2, 3, linux.c7i.2xlarge), dynamo-unittest / dynamo-test (3.12) / test (dynamo_wrapped, 3, 3, linux.c7i.2xlarge), trunk / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, lf.linux.2xlarge, unstable) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…ct; enable nested graph break tests on test_functions.py (#167694) The iterator push in FOR_ITER must be done before attempting to call next_variable because if next_variable graph breaks with nested graph breaks on, the iterator must be on the stack to resume properly. Pull Request resolved: #167694 Approved by: https://github.com/StrongerXi
…ct; enable nested graph break tests on test_functions.py ghstack-source-id: b902981 Pull Request resolved: pytorch/pytorch#167694
Stack from ghstack (oldest at bottom):
The iterator push in FOR_ITER must be done before attempting to call next_variable because if next_variable graph breaks with nested graph breaks on, the iterator must be on the stack to resume properly.
cc @mlazos @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela