DTensor fast path: port return_and_correct_aliasing and inplace/out checks#167475
Closed
swolchok wants to merge 11 commits intogh/swolchok/867/basefrom
Closed
DTensor fast path: port return_and_correct_aliasing and inplace/out checks#167475swolchok wants to merge 11 commits intogh/swolchok/867/basefrom
swolchok wants to merge 11 commits intogh/swolchok/867/basefrom
Conversation
…out checks This seems to generate a several-microsecond performance improvement in the detach benchmark I've been using. [ghstack-poisoned]
This was referenced Nov 10, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167475
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit c96e842 with merge base 780e325 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
oncall: distributed
…h: port return_and_correct_aliasing and inplace/out checks" This seems to generate a several-microsecond performance improvement in the detach benchmark I've been using. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…rect_aliasing and inplace/out checks" This seems to generate a several-microsecond performance improvement in the detach benchmark I've been using. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…t arguments for local dispatch, and failure to return a list (was pushing multiple retvals onto stack) for list returning ops on "WIP: DTensor fast path: port return_and_correct_aliasing and inplace/out checks" This seems to generate a several-microsecond performance improvement in the detach benchmark I've been using. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
… path: port return_and_correct_aliasing and inplace/out checks" This seems to generate a several-microsecond performance improvement in the detach benchmark I've been using. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…rn_and_correct_aliasing and inplace/out checks" This seems to generate a several-microsecond performance improvement in the detach benchmark I've been using. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…eturn_and_correct_aliasing and inplace/out checks" This seems to generate a several-microsecond performance improvement in the detach benchmark I've been using. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
swolchok
changed the title
…and_correct_aliasing and inplace/out checks" This seems to generate a several-microsecond performance improvement in the detach benchmark I've been using. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
ezyang
reviewed
Nov 12, 2025
| # simple analysis of function schema to determine | ||
| # if this is an inplace variant, it might not | ||
| # be entirely correct, but it's good enough for now. | ||
| return self.op._schema.name[-1] == "_" |
Contributor
Author
There was a problem hiding this comment.
just putting it back since we don't need the standalone function anymore (see changes in _dispatch.py)
ezyang
reviewed
Nov 12, 2025
| } | ||
| } | ||
| stack->clear(); | ||
| return wrapped_result; |
Contributor
There was a problem hiding this comment.
This is probably possible to do better now that it's in C++, but FUTURE WORK.
ezyang
approved these changes
Nov 12, 2025
…comments on "DTensor fast path: port return_and_correct_aliasing and inplace/out checks" This seems to generate a several-microsecond performance improvement in the detach benchmark I've been using. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…ensor on "DTensor fast path: port return_and_correct_aliasing and inplace/out checks" This seems to generate a several-microsecond performance improvement in the detach benchmark I've been using. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
…ort return_and_correct_aliasing and inplace/out checks" This seems to generate a several-microsecond performance improvement in the detach benchmark I've been using. cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge -i |
Collaborator
Merge startedYour change will be merged while ignoring the following 1 checks: trunk / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, lf.linux.2xlarge, unstable) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
…hecks (pytorch#167475) This seems to generate a several-microsecond performance improvement in the detach benchmark I've been using. Pull Request resolved: pytorch#167475 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#167051, pytorch#166372, pytorch#166808
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 21, 2025
``` git revert --no-commit 567dcdb 200156e 3d801a4 2034ca9 480b4ff f570e58 ``` And Revert "[DTensor] Document fast-path dispatch (#168192)" And Revert "[DTensor] Fix deadlock after fast cache clear (#168069)" Reverts: * #167860 * #167588 * #167475 * #166808 * #166372 * #168192 * #168069 Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: #168264 Approved by: https://github.com/seemethere, https://github.com/malfet
JacobSzwejbka
pushed a commit
that referenced
this pull request
Dec 8, 2025
``` git revert --no-commit 567dcdb 200156e 3d801a4 2034ca9 480b4ff f570e58 ``` And Revert "[DTensor] Document fast-path dispatch (#168192)" And Revert "[DTensor] Fix deadlock after fast cache clear (#168069)" Reverts: * #167860 * #167588 * #167475 * #166808 * #166372 * #168192 * #168069 Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: #168264 Approved by: https://github.com/seemethere, https://github.com/malfet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
DTensor.__torch_dispatch__#167051This seems to generate a several-microsecond performance improvement in the detach benchmark I've been using.
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci