Add guidance on how to migrate kernels to the libtorch stable ABI #167112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167112
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 54ed4b3 with merge base c724f00 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…ble ABI" [ghstack-poisoned]
…ble ABI" [ghstack-poisoned]
…ble ABI" [ghstack-poisoned]
…ble ABI" [ghstack-poisoned]
…ble ABI" [ghstack-poisoned]
janeyx99
reviewed
Nov 5, 2025
| // Put result back on stack using `from()` | ||
| // Stack slot 0 now holds the return value | ||
| stack[0] = from(result); |
Contributor
There was a problem hiding this comment.
oooh should we also cherrypick the torch::stable::detail::from change + migrate these to use that? (general q for outside of this PR)
…ble ABI" [ghstack-poisoned]
…ble ABI" [ghstack-poisoned]
…ble ABI" [ghstack-poisoned]
…ble ABI" [ghstack-poisoned]
…ble ABI" [ghstack-poisoned]
janeyx99
reviewed
Nov 6, 2025
janeyx99
approved these changes
Nov 6, 2025
…ble ABI" [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
mikaylagawarecki
added
release notes: cpp
yarongmu-google
pushed a commit
to yarongmu-google/pytorch
that referenced
this pull request
Nov 7, 2025
mikaylagawarecki
added a commit
to mikaylagawarecki/pytorch
that referenced
this pull request
Nov 7, 2025
This was referenced Nov 7, 2025
atalman
pushed a commit
that referenced
this pull request
Nov 7, 2025
… (#167323) * [BE] Refresh documentation for stable ABI / API (#163899) Pull Request resolved: #163899 Approved by: https://github.com/janeyx99 * Document LibTorch ABI more, add README to headeronly (#166661) Pull Request resolved: #166661 Approved by: https://github.com/mikaylagawarecki, https://github.com/albanD * Add guidance on how to migrate kernels to the libtorch stable ABI (#167112) Pull Request resolved: #167112 Approved by: https://github.com/janeyx99 --------- Co-authored-by: Jane Xu <[email protected]>
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):