Fix static linkage cases and NO_DISTRIBUTED=1 + CUDA #16705
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumith
force-pushed
the
buildsfix_static
branch
from
445e8e9 to
8d236dc
Compare
pjh5
approved these changes
Feb 4, 2019
Contributor
pjh5
left a comment
pjh5
left a comment
There was a problem hiding this comment.
Confirmed that builds pass with these changes
Contributor
Author
|
@pjh5 do you know why CI "binary" builds are failing? |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 5, 2019
Differential Revision: D13952085 Pulled By: soumith fbshipit-source-id: 410c4e117a44c08eadc6f3ded91fafc320a7c696
Contributor
|
The CUDA failures were real. I'm reverting this. |
soumith
added a commit
that referenced
this pull request
Feb 21, 2019
Differential Revision: D13952085 Pulled By: soumith fbshipit-source-id: 410c4e117a44c08eadc6f3ded91fafc320a7c696
soumith
added a commit
that referenced
this pull request
Feb 21, 2019
Differential Revision: D13952085 Pulled By: soumith fbshipit-source-id: 410c4e117a44c08eadc6f3ded91fafc320a7c696
soumith
added a commit
that referenced
this pull request
Feb 21, 2019
Differential Revision: D13952085 Pulled By: soumith fbshipit-source-id: 410c4e117a44c08eadc6f3ded91fafc320a7c696
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Feb 22, 2019
Summary: Attempt #2 (attempt 1 is pytorch/pytorch#16705 and got reverted because of CI failures) Fixes pytorch/pytorch#14805 Pull Request resolved: pytorch/pytorch#17337 Differential Revision: D14175626 Pulled By: soumith fbshipit-source-id: 66f2e10e219a1bf88ed342ec5c89da6f2994d8eb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @pjh5
Fixes case where: