Delete deprecated fp32 precision warnings (#166956) #166998
Merged
+0
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166998
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit f904e71 with merge base 4840a1a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
cc @zou3519 @BoyuanFeng to validate this manual cherrypick looks correct |
zou3519
reviewed
Nov 4, 2025
| #endif | ||
| namespace at { | ||
|
|
||
| namespace { |
Contributor
There was a problem hiding this comment.
er don't you still need the anonymous namespace?
Contributor
Author
There was a problem hiding this comment.
Yep patching that on my end
The deprecation warning led to warning spamming in PyTorch APIs, like torch.compile. This is not how a deprecation warning should go: if we add a deprecation warning, we'd better update our built-in APIs to prevent warning spam. Pull Request resolved: #166956 Approved by: https://github.com/albanD (cherry picked from commit 527b110)
Lucaskabela
force-pushed
the
cherrypick_166956
branch
from
e860e2f to
f904e71
Compare
zou3519
approved these changes
Nov 4, 2025
Contributor
zou3519
left a comment
zou3519
left a comment
There was a problem hiding this comment.
lgtm as long as it compiles
atalman
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecation warning led to warning spamming in PyTorch APIs, like torch.compile. This is not how a deprecation warning should go: if we add a deprecation warning, we'd better update our built-in APIs to prevent warning spam.
Pull Request resolved: #166956 Approved by: https://github.com/albanD
(cherry picked from commit 527b110)
Fixes #166286