[GraphPartition] cache get_free_symbol_uses (#166338) #166994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166994
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 97cb547 with merge base 4840a1a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
cc @BoyuanFeng to review cherrypick conflict resolution |
Contributor
|
The test fails on release/2.9 but not on main branch. The unit test is added by the same PR to check the FlexibleLayout does not change free symbol uses. However, the unit test needs #163639 to run. I have validated that the test passed when patching #163639. Since we don't want to cherry-pick #163639, this PR will cherry pick #166338 without the test |
BoyuanFeng
approved these changes
Nov 4, 2025
Lucaskabela
force-pushed
the
cherrypick_166338
branch
from
ffb2f3b to
bed779a
Compare
Graph partition relies on `get_free_symbol_uses()` to collect symbol inputs. https://github.com/pytorch/pytorch/blob/ee7434be822cf6e75b4566d8159f550ee233d8ae/torch/_inductor/scheduler.py#L4869-L4885 I empirically observed that `get_free_symbol_uses()` becomes slower for larger graphs. Specifically, I tried to aten fallback for torchtitan which results in 10k+ aten nodes. When processing the 600-th node, it takes seconds to `get_free_symbol_uses()` for 1 node. Why? Because `get_free_symbol_uses()` may recursively call another `get_free_symbol_uses()`, which could recursively run many times. https://github.com/pytorch/pytorch/blob/ee7434be822cf6e75b4566d8159f550ee233d8ae/torch/_inductor/ir.py#L4541-L4543 This PR fixes the issue by caching the results of `get_free_symbol_uses()`. I validated on torchtitan that the issue is fixed. Pull Request resolved: #166338 Approved by: https://github.com/eellison (cherry picked from commit dfebdca)
Lucaskabela
force-pushed
the
cherrypick_166338
branch
from
bed779a to
97cb547
Compare
atalman
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graph partition relies on
get_free_symbol_uses()to collect symbol inputs.pytorch/torch/_inductor/scheduler.py
Lines 4869 to 4885 in ee7434b
I empirically observed that
get_free_symbol_uses()becomes slower for larger graphs. Specifically, I tried to aten fallback for torchtitan which results in 10k+ aten nodes. When processing the 600-th node, it takes seconds toget_free_symbol_uses()for 1 node.Why? Because
get_free_symbol_uses()may recursively call anotherget_free_symbol_uses(), which could recursively run many times.pytorch/torch/_inductor/ir.py
Lines 4541 to 4543 in ee7434b
This PR fixes the issue by caching the results of
get_free_symbol_uses(). I validated on torchtitan that the issue is fixed.Pull Request resolved: #166338
(cherry picked from commit dfebdca)
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben