Skip to content

don't produce invalid grid configs #166974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ngimel wants to merge 2 commits into from
Closed

don't produce invalid grid configs #166974

ngimel wants to merge 2 commits into from

Conversation

@ngimel
Copy link
Collaborator

@ngimel ngimel commented Nov 4, 2025

Proper fix for #164048, fixes gather too, reverts #164049

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166974

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 246e9fe with merge base d02f68f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ngimel ngimel added release notes: cuda release notes category topic: bug fixes topic category labels Nov 4, 2025
@ngimel
Copy link
Collaborator Author

ngimel commented Nov 4, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 4, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 4, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 4, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-cuda12.8-py3.10-gcc11 / test (default, 3, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@ngimel
Copy link
Collaborator Author

ngimel commented Nov 4, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 4, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ngimel added a commit that referenced this pull request Nov 5, 2025
@ngimel
don't produce invalid grid configs (#166973)
8698f04 
Proper fix for #164048, fixes gather too, reverts #164049
Pull Request resolved: #166974
Approved by: https://github.com/eqy
This was referenced Nov 5, 2025
Merged
Closed
atalman pushed a commit that referenced this pull request Nov 6, 2025
@ngimel
don't produce invalid grid configs (#166973) (#167158)
8f658d7 
Proper fix for #164048, fixes gather too, reverts #164049
Pull Request resolved: #166974
Approved by: https://github.com/eqy
@github-actions github-actions bot deleted the ngimel/gather_grid branch December 5, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eqy eqy eqy approved these changes

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

@Aidyn-A Aidyn-A Awaiting requested review from Aidyn-A Aidyn-A is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: cuda release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ngimel @pytorchmergebot @eqy