[dynamo] fix keyerror in resume_execution, fix store attr #166924
Merged
+153
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #166033 Differential Revision: [D85198055](https://our.internmc.facebook.com/intern/diff/D85198055) Pull Request resolved: #166036 Approved by: https://github.com/Lucaskabela (cherry picked from commit ebb2b2e)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166924
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit abd9ef2 with merge base 4840a1a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Lucaskabela
force-pushed
the
cherry_pick_166036_166040
branch
2 times, most recently
from
66250f2 to
e328b4c
Compare
Lucaskabela
commented
Nov 4, 2025
test/dynamo/test_repros.py
Outdated
| x = x + 8 | ||
| return x + 16 | ||
| x = x + 1 + 2 | ||
| torch._dynamo.step_unsupported() |
Contributor
Author
There was a problem hiding this comment.
cc @williamwen42 this doesn't exist on release/2.9... should we just remove this testcase?
Member
There was a problem hiding this comment.
This test is coming from #162737 which we're not cherry picking? So we can probably just remove this test case.
Lucaskabela
force-pushed
the
cherry_pick_166036_166040
branch
from
e328b4c to
89b01de
Compare
Lucaskabela
commented
Nov 4, 2025
| def find_orig_offset(cur_offset: int) -> int: | ||
| orig_offset = -1 | ||
|
|
||
| def find_orig_offset_transform( |
Contributor
Author
There was a problem hiding this comment.
cc @williamwen42 this code is also causing a breakage since (target,) is not able to be unpacked. Any thoughts on the right change to support this?
Fixes #166176 The error I attempted to fix in #162318 was still appearing internally. Surprised that this wasn't caught anywhere 😰 Pull Request resolved: #166040 Approved by: https://github.com/Lucaskabela ghstack dependencies: #166036 (cherry picked from commit 32fe4f6)
Lucaskabela
force-pushed
the
cherry_pick_166036_166040
branch
from
89b01de to
61e1943
Compare
williamwen42
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166176
See also stack on #166036
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames