[Inductor] No longer throw error in bmm out_dtype lowering due to tem… #166922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166922
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit be30e2f with merge base 4840a1a ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
Seems we also need this stack: #161350 - @PaulZhang12 can you confirm? I may not have enough context to support cherrypicking this particular feature so may have to turn this over to you if the change is more involved |
Contributor
Author
|
Actually looking at the original PR, I don't think the template stuff is needed, just the assert removal, so I am going to try that change |
Lucaskabela
force-pushed
the
cherry_pick_166457
branch
from
0bf7958 to
3ee578a
Compare
PaulZhang12
approved these changes
Nov 4, 2025
Contributor
Author
|
Thanks @PaulZhang12! Let's wait for dev team to merge this but glad it looks good from your end |
Contributor
|
Failure not related to the PR |
PaulZhang12
force-pushed
the
cherry_pick_166457
branch
from
3ee578a to
2685d6d
Compare
pytorch-bot
bot
added
ciflow/b200
ciflow/h100
ciflow/rocm
PaulZhang12
force-pushed
the
cherry_pick_166457
branch
from
2685d6d to
31230bb
Compare
…plate heuristics (#166457) Fixes #165892 Pull Request resolved: #166457 Approved by: https://github.com/coconutruben (cherry picked from commit c2e3cc7)
PaulZhang12
force-pushed
the
cherry_pick_166457
branch
from
31230bb to
be30e2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…plate heuristics (#166457)
(cherry picked from commit c2e3cc7)
Fixes #165892
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben