Skip to content

[dynamo, nested graph breaks] disallow graph breaks in functorch ops, enable nested graph break tests on test_higher_order_ops.py #166674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
williamwen42 wants to merge 8 commits into from
Closed

[dynamo, nested graph breaks] disallow graph breaks in functorch ops, enable nested graph break tests on test_higher_order_ops.py #166674

williamwen42 wants to merge 8 commits into from

Conversation

@williamwen42
Copy link
Member

@williamwen42 williamwen42 commented Oct 30, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela

@williamwen42
[dynamo, nested graph breaks] disallow graph breaks in functorch ops,…
adba8e6 
… enable nested graph break tests on test_higher_order_ops.py

[ghstack-poisoned]
@williamwen42 williamwen42 requested a review from zou3519 as a code owner October 30, 2025 23:52
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 30, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166674

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit d8e347b with merge base 9b68682 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Oct 30, 2025
Closed
Closed
This was referenced Oct 30, 2025
Closed
Closed
Closed
Open
Open
Open
@williamwen42 williamwen42 added the topic: not user facing topic category label Oct 31, 2025
@williamwen42
Update on "[dynamo, nested graph breaks] disallow graph breaks in fun…
afcf8a0 
…ctorch ops, enable nested graph break tests on test_higher_order_ops.py"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]
@williamwen42
Update on "[dynamo, nested graph breaks] disallow graph breaks in fun…
8737016 
…ctorch ops, enable nested graph break tests on test_higher_order_ops.py"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]
@williamwen42
Update
ed74c49 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 31, 2025

Rebased gh/williamwen42/297/orig onto refs/remotes/origin/viable/strict because #163503 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/166674)

@williamwen42
Update on "[dynamo, nested graph breaks] disallow graph breaks in fun…
cf88f21 
…ctorch ops, enable nested graph break tests on test_higher_order_ops.py"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]
zou3519
zou3519 reviewed Nov 4, 2025
View reviewed changes
test/dynamo/test_higher_order_ops.py


class TestHigherOrderOpsOpInfo(torch._dynamo.test_case.TestCase):
class TestHigherOrderOpsOpInfo(torch._dynamo.test_case.TestCaseWithNestedGraphBreaks):
Copy link
Contributor

@zou3519 zou3519 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an explanation of what TestCaseWithNestedGraphBreaks does?

Copy link
Member Author

@williamwen42 williamwen42 Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defined here:

pytorch/torch/_dynamo/test_case.py

Line 118 in 74e85c6

class TestCaseWithNestedGraphBreaks(TestCase):
just wraps test with _dynamo.config.nested_graph_breaks = True so we don't need to continue to patch this config.

zou3519
zou3519 reviewed Nov 4, 2025
View reviewed changes
test/dynamo/test_nested_graph_breaks.py
Comment on lines 898 to 899
self.assertEqual(cnts.frame_count, 2)
self.assertEqual(cnts.op_count, 4)
Copy link
Contributor

@zou3519 zou3519 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which frames and which ops? thinking is hard lol

Copy link
Member Author

@williamwen42 williamwen42 Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments to test

zou3519
zou3519 reviewed Nov 4, 2025
View reviewed changes
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me but I'd like some more details about what's going on

@williamwen42
Update on "[dynamo, nested graph breaks] disallow graph breaks in fun…
7bd610e 
…ctorch ops, enable nested graph break tests on test_higher_order_ops.py"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]
@williamwen42
Update on "[dynamo, nested graph breaks] disallow graph breaks in fun…
5962de9 
…ctorch ops, enable nested graph break tests on test_higher_order_ops.py"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]
This was referenced Nov 13, 2025
Closed
Open
@williamwen42
Copy link
Member Author

williamwen42 commented Nov 13, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 13, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 13, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 13, 2025

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@williamwen42
Update on "[dynamo, nested graph breaks] disallow graph breaks in fun…
d8e347b 
…ctorch ops, enable nested graph break tests on test_higher_order_ops.py"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]
@williamwen42
Copy link
Member Author

williamwen42 commented Nov 13, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 13, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Khanaksahu pushed a commit to Khanaksahu/pytorch that referenced this pull request Nov 17, 2025
@williamwen42
[dynamo, nested graph breaks] disallow graph breaks in functorch ops,…
f99e504 
… enable nested graph break tests on test_higher_order_ops.py

ghstack-source-id: a730694
Pull Request resolved: pytorch/pytorch#166674
Silv3S pushed a commit to Silv3S/pytorch that referenced this pull request Nov 18, 2025
@williamwen42 @Silv3S
[dynamo, nested graph breaks] disallow graph breaks in functorch ops,…
d4967ab 
… enable nested graph break tests on test_higher_order_ops.py (pytorch#166674)

Pull Request resolved: pytorch#166674
Approved by: https://github.com/ydwu4
ghstack dependencies: pytorch#166673
@github-actions github-actions bot deleted the gh/williamwen42/326/head branch December 14, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 left review comments

@ydwu4 ydwu4 ydwu4 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@williamwen42 @pytorchmergebot @zou3519 @ydwu4