[dynamo, nested graph breaks] add disable_nested_graph_breaks decorator/context manager #166477

williamwen42 · 2025-10-29T00:43:24Z

Stack from ghstack (oldest at bottom):

[dynamo] fix error_on_graph_break bug where non-empty checkpoint results in unwanted graph break resumption #166586
-> [dynamo, nested graph breaks] add disable_nested_graph_breaks decorator/context manager #166477
[dynamo, nested graph breaks] codegen dead nested cells correctly #166476

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela

…or/context manager [ghstack-poisoned]

pytorch-bot · 2025-10-29T00:43:27Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166477

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 9e68d14 with merge base df71b70 ():
💚 Looks good so far! There are no failures yet. 💚

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

⏳ trunk / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, lf.linux.2xlarge, unstable) (gh) (#166072)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

williamwen42 · 2025-10-29T17:36:55Z

@pytorchbot merge

pytorchmergebot · 2025-10-29T17:38:54Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-10-29T23:37:22Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

williamwen42 · 2025-10-30T00:59:28Z

@pytorchbot merge

pytorchmergebot · 2025-10-30T01:01:36Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-10-30T07:00:07Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

williamwen42 · 2025-10-30T17:49:12Z

@pytorchbot merge

pytorchmergebot · 2025-10-30T17:51:09Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-10-30T18:00:06Z

Starting merge as part of PR stack under #166586

pytorchmergebot · 2025-10-30T23:49:37Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

pytorchmergebot · 2025-10-31T00:08:15Z

Starting merge as part of PR stack under #166586

[ghstack-poisoned]

pytorchmergebot · 2025-10-31T00:50:56Z

Rebased gh/williamwen42/322/orig onto refs/remotes/origin/viable/strict because #166586 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/166477)

pytorchmergebot · 2025-10-31T00:57:12Z

Starting merge as part of PR stack under #166586

…lts in unwanted graph break resumption (#166586) Fixes #166589 Pull Request resolved: #166586 Approved by: https://github.com/Lucaskabela ghstack dependencies: #166476, #166477

…66587) Pull Request resolved: #166587 Approved by: https://github.com/Lucaskabela ghstack dependencies: #166476, #166477, #166586

…or/context manager (#166477) Pull Request resolved: #166477 Approved by: https://github.com/Lucaskabela, https://github.com/Skylion007 ghstack dependencies: #166476

…lts in unwanted graph break resumption (#166586) Fixes #166589 Pull Request resolved: #166586 Approved by: https://github.com/Lucaskabela ghstack dependencies: #166476, #166477

…66587) Pull Request resolved: #166587 Approved by: https://github.com/Lucaskabela ghstack dependencies: #166476, #166477, #166586

…lts in unwanted graph break resumption (#166586) Fixes #166589 Pull Request resolved: #166586 Approved by: https://github.com/Lucaskabela ghstack dependencies: #166476, #166477 (cherry picked from commit 267d019)

…or/context manager (pytorch#166477) Pull Request resolved: pytorch#166477 Approved by: https://github.com/Lucaskabela, https://github.com/Skylion007 ghstack dependencies: pytorch#166476

…lts in unwanted graph break resumption (pytorch#166586) Fixes pytorch#166589 Pull Request resolved: pytorch#166586 Approved by: https://github.com/Lucaskabela ghstack dependencies: pytorch#166476, pytorch#166477

…torch#166587) Pull Request resolved: pytorch#166587 Approved by: https://github.com/Lucaskabela ghstack dependencies: pytorch#166476, pytorch#166477, pytorch#166586

…lts in unwanted graph break resumption (#166925) [dynamo] fix error_on_graph_break bug where non-empty checkpoint results in unwanted graph break resumption (#166586) Fixes #166589 Pull Request resolved: #166586 Approved by: https://github.com/Lucaskabela ghstack dependencies: #166476, #166477 (cherry picked from commit 267d019) Co-authored-by: William Wen <[email protected]>

…or/context manager ghstack-source-id: 7fbbd72 Pull Request resolved: pytorch/pytorch#166477

…or/context manager ghstack-source-id: 68e9a02 Pull Request resolved: pytorch/pytorch#166477

[dynamo, nested graph breaks] add disable_nested_graph_breaks decorat…

8e23906

…or/context manager [ghstack-poisoned]

williamwen42 mentioned this pull request Oct 29, 2025

[dynamo, nested graph breaks] codegen dead nested cells correctly #166476

Closed

pytorch-bot bot added ciflow/inductor module: dynamo labels Oct 29, 2025

Lucaskabela approved these changes Oct 29, 2025

View reviewed changes

Skylion007 approved these changes Oct 29, 2025

View reviewed changes

williamwen42 added the topic: not user facing topic category label Oct 29, 2025

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 29, 2025

pytorchmergebot added the merging label Oct 29, 2025

This was referenced Oct 29, 2025

[dynamo] fix error_on_graph_break bug where non-empty checkpoint results in unwanted graph break resumption #166586

Closed

[dynamo] clarify graph break handling/logging in symbolic_convert #166587

Closed

This was referenced Oct 30, 2025

[dynamo] clean up BaseUserFunctionVariable and LocalGeneratorObjectVariable #166673

Closed

[dynamo, nested graph breaks] disallow graph breaks in functorch ops, enable nested graph break tests on test_higher_order_ops.py #166674

Closed

Update

9e68d14

[ghstack-poisoned]

pytorchmergebot closed this in 1dec8a6 Oct 31, 2025

pytorchmergebot added the Merged label Oct 31, 2025

Khanaksahu pushed a commit to Khanaksahu/pytorch that referenced this pull request Nov 17, 2025

[dynamo, nested graph breaks] add disable_nested_graph_breaks decorat…

d3886ce

…or/context manager ghstack-source-id: 7fbbd72 Pull Request resolved: pytorch/pytorch#166477

Khanaksahu pushed a commit to Khanaksahu/pytorch-fork that referenced this pull request Nov 17, 2025

[dynamo, nested graph breaks] add disable_nested_graph_breaks decorat…

9ec0dd7

…or/context manager ghstack-source-id: 68e9a02 Pull Request resolved: pytorch/pytorch#166477

github-actions bot deleted the gh/williamwen42/321/head branch December 1, 2025 02:21

[dynamo, nested graph breaks] add disable_nested_graph_breaks decorator/context manager #166477

[dynamo, nested graph breaks] add disable_nested_graph_breaks decorator/context manager #166477

Uh oh!

Conversation

williamwen42 commented Oct 29, 2025 • edited by pytorchmergebot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166477

⏳ No Failures, 1 Pending

Uh oh!

williamwen42 commented Oct 29, 2025

Uh oh!

pytorchmergebot commented Oct 29, 2025

Merge started

Uh oh!

pytorchmergebot commented Oct 29, 2025

Uh oh!

williamwen42 commented Oct 30, 2025

Uh oh!

pytorchmergebot commented Oct 30, 2025

Merge started

Uh oh!

pytorchmergebot commented Oct 30, 2025

Uh oh!

williamwen42 commented Oct 30, 2025

Uh oh!

pytorchmergebot commented Oct 30, 2025

Merge started

Uh oh!

pytorchmergebot commented Oct 30, 2025

Uh oh!

pytorchmergebot commented Oct 30, 2025

Uh oh!

pytorchmergebot commented Oct 31, 2025

Uh oh!

pytorchmergebot commented Oct 31, 2025

Uh oh!

pytorchmergebot commented Oct 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

williamwen42 commented Oct 29, 2025 •

edited by pytorchmergebot

Loading

pytorch-bot bot commented Oct 29, 2025 •

edited

Loading