Skip to content

[dynamo, nested graph breaks] codegen dead nested cells correctly #166476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
williamwen42 wants to merge 2 commits into from
Closed

[dynamo, nested graph breaks] codegen dead nested cells correctly #166476

williamwen42 wants to merge 2 commits into from

Conversation

@williamwen42
Copy link
Member

@williamwen42 williamwen42 commented Oct 29, 2025 •
edited by pytorchmergebot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 29, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166476

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 93f13ee with merge base df71b70 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Oct 29, 2025
Closed
Open
Open
Open
Lucaskabela
Lucaskabela approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@Lucaskabela Lucaskabela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clearly documenting the issue in the testcase and adding the context to side effects!

@williamwen42 williamwen42 added the topic: not user facing topic category label Oct 29, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 29, 2025

Starting merge as part of PR stack under #166477

This was referenced Oct 29, 2025
Closed
Closed
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 30, 2025

Starting merge as part of PR stack under #166477

1 similar comment
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 30, 2025

Starting merge as part of PR stack under #166477

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 30, 2025

Starting merge as part of PR stack under #166586

This was referenced Oct 30, 2025
Closed
Closed
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 31, 2025

Starting merge as part of PR stack under #166586

@williamwen42
Update
93f13ee 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 31, 2025

Rebased gh/williamwen42/322/orig onto refs/remotes/origin/viable/strict because #166586 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/166476)

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 31, 2025

Starting merge as part of PR stack under #166586

pytorchmergebot pushed a commit that referenced this pull request Oct 31, 2025
@williamwen42 @pytorchmergebot
[dynamo, nested graph breaks] add disable_nested_graph_breaks decorat…
1dec8a6 
…or/context manager (#166477)

Pull Request resolved: #166477
Approved by: https://github.com/Lucaskabela, https://github.com/Skylion007
ghstack dependencies: #166476
pytorchmergebot pushed a commit that referenced this pull request Oct 31, 2025
@williamwen42 @pytorchmergebot
[dynamo] fix error_on_graph_break bug where non-empty checkpoint resu…
267d019 
…lts in unwanted graph break resumption (#166586)

Fixes #166589

Pull Request resolved: #166586
Approved by: https://github.com/Lucaskabela
ghstack dependencies: #166476, #166477
pytorchmergebot pushed a commit that referenced this pull request Oct 31, 2025
@williamwen42 @pytorchmergebot
[dynamo] clarify graph break handling/logging in symbolic_convert (#1…
70aeb49 
…66587)

Pull Request resolved: #166587
Approved by: https://github.com/Lucaskabela
ghstack dependencies: #166476, #166477, #166586
BoyuanFeng pushed a commit that referenced this pull request Oct 31, 2025
@williamwen42 @BoyuanFeng
[dynamo, nested graph breaks] codegen dead nested cells correctly (#1…
c879936 
…66476)

Pull Request resolved: #166476
Approved by: https://github.com/Lucaskabela
BoyuanFeng pushed a commit that referenced this pull request Oct 31, 2025
@williamwen42 @BoyuanFeng
[dynamo, nested graph breaks] add disable_nested_graph_breaks decorat…
9e226a7 
…or/context manager (#166477)

Pull Request resolved: #166477
Approved by: https://github.com/Lucaskabela, https://github.com/Skylion007
ghstack dependencies: #166476
BoyuanFeng pushed a commit that referenced this pull request Oct 31, 2025
@williamwen42 @BoyuanFeng
[dynamo] fix error_on_graph_break bug where non-empty checkpoint resu…
713b7c9 
…lts in unwanted graph break resumption (#166586)

Fixes #166589

Pull Request resolved: #166586
Approved by: https://github.com/Lucaskabela
ghstack dependencies: #166476, #166477
BoyuanFeng pushed a commit that referenced this pull request Oct 31, 2025
@williamwen42 @BoyuanFeng
[dynamo] clarify graph break handling/logging in symbolic_convert (#1…
63fbd7c 
…66587)

Pull Request resolved: #166587
Approved by: https://github.com/Lucaskabela
ghstack dependencies: #166476, #166477, #166586
Lucaskabela pushed a commit that referenced this pull request Nov 4, 2025
@williamwen42 @Lucaskabela
[dynamo] fix error_on_graph_break bug where non-empty checkpoint resu…
a3a4316 
…lts in unwanted graph break resumption (#166586)

Fixes #166589

Pull Request resolved: #166586
Approved by: https://github.com/Lucaskabela
ghstack dependencies: #166476, #166477

(cherry picked from commit 267d019)
Lucaskabela pushed a commit that referenced this pull request Nov 4, 2025
@williamwen42 @Lucaskabela
[dynamo] fix error_on_graph_break bug where non-empty checkpoint resu…
1f961fc 
…lts in unwanted graph break resumption (#166586)

Fixes #166589

Pull Request resolved: #166586
Approved by: https://github.com/Lucaskabela
ghstack dependencies: #166476, #166477

(cherry picked from commit 267d019)
etaf pushed a commit to etaf/pytorch-inductor-xpu that referenced this pull request Nov 4, 2025
@williamwen42 @etaf
[dynamo, nested graph breaks] codegen dead nested cells correctly (py…
071de0f 
…torch#166476)

Pull Request resolved: pytorch#166476
Approved by: https://github.com/Lucaskabela
etaf pushed a commit to etaf/pytorch-inductor-xpu that referenced this pull request Nov 4, 2025
@williamwen42 @etaf
[dynamo, nested graph breaks] add disable_nested_graph_breaks decorat…
f7dba53 
…or/context manager (pytorch#166477)

Pull Request resolved: pytorch#166477
Approved by: https://github.com/Lucaskabela, https://github.com/Skylion007
ghstack dependencies: pytorch#166476
etaf pushed a commit to etaf/pytorch-inductor-xpu that referenced this pull request Nov 4, 2025
@williamwen42 @etaf
[dynamo] fix error_on_graph_break bug where non-empty checkpoint resu…
24c4147 
…lts in unwanted graph break resumption (pytorch#166586)

Fixes pytorch#166589

Pull Request resolved: pytorch#166586
Approved by: https://github.com/Lucaskabela
ghstack dependencies: pytorch#166476, pytorch#166477
etaf pushed a commit to etaf/pytorch-inductor-xpu that referenced this pull request Nov 4, 2025
@williamwen42 @etaf
[dynamo] clarify graph break handling/logging in symbolic_convert (py…
060258a 
…torch#166587)

Pull Request resolved: pytorch#166587
Approved by: https://github.com/Lucaskabela
ghstack dependencies: pytorch#166476, pytorch#166477, pytorch#166586
atalman pushed a commit that referenced this pull request Nov 5, 2025
@Lucaskabela @williamwen42
[dynamo] fix error_on_graph_break bug where non-empty checkpoint resu…
8e83e24 
…lts in unwanted graph break resumption (#166925)

[dynamo] fix error_on_graph_break bug where non-empty checkpoint results in unwanted graph break resumption (#166586)

Fixes #166589

Pull Request resolved: #166586
Approved by: https://github.com/Lucaskabela
ghstack dependencies: #166476, #166477

(cherry picked from commit 267d019)

Co-authored-by: William Wen <[email protected]>
Khanaksahu pushed a commit to Khanaksahu/pytorch that referenced this pull request Nov 17, 2025
@williamwen42
[dynamo, nested graph breaks] codegen dead nested cells correctly
a128820 
ghstack-source-id: 80a2fb1
Pull Request resolved: pytorch/pytorch#166476
Khanaksahu pushed a commit to Khanaksahu/pytorch that referenced this pull request Nov 17, 2025
@williamwen42 @pytorchmergebot
[dynamo, nested graph breaks] codegen dead nested cells correctly
5a85f50 
ghstack-source-id: d0e4c98
Pull Request resolved: pytorch/pytorch#166476
@github-actions github-actions bot deleted the gh/williamwen42/320/head branch December 1, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lucaskabela Lucaskabela Lucaskabela approved these changes

Assignees

No one assigned

Labels

ciflow/inductor Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@williamwen42 @pytorchmergebot @Lucaskabela