[Inductor] No longer throw error in bmm out_dtype lowering due to template heuristics #166457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166457
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6257c73 with merge base fea819e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
PaulZhang12
changed the title
… due to template heuristics" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
coconutruben
approved these changes
Oct 28, 2025
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
BoyuanFeng
pushed a commit
that referenced
this pull request
Oct 31, 2025
…plate heuristics (#166457) Fixes #165892 Pull Request resolved: #166457 Approved by: https://github.com/coconutruben
Contributor
|
@pytorchbot cherry-pick --onto release/2.9 --fixes "bmm + torch.compile breakage in 2.9 from heuristic change #165892" -c regression |
Collaborator
Cherry picking #166457Command Details for Dev Infra teamRaised by workflow job |
Lucaskabela
pushed a commit
that referenced
this pull request
Nov 4, 2025
…plate heuristics (#166457) Fixes #165892 Pull Request resolved: #166457 Approved by: https://github.com/coconutruben (cherry picked from commit c2e3cc7)
Contributor
|
I will try to get this cherry-pick request tomorrow |
Lucaskabela
pushed a commit
that referenced
this pull request
Nov 4, 2025
…plate heuristics (#166457) Fixes #165892 Pull Request resolved: #166457 Approved by: https://github.com/coconutruben (cherry picked from commit c2e3cc7)
Lucaskabela
pushed a commit
that referenced
this pull request
Nov 4, 2025
…plate heuristics (#166457) Fixes #165892 Pull Request resolved: #166457 Approved by: https://github.com/coconutruben (cherry picked from commit c2e3cc7)
PaulZhang12
added a commit
that referenced
this pull request
Nov 6, 2025
…plate heuristics (#166457) Fixes #165892 Pull Request resolved: #166457 Approved by: https://github.com/coconutruben (cherry picked from commit c2e3cc7)
PaulZhang12
added a commit
that referenced
this pull request
Nov 6, 2025
…plate heuristics (#166457) Fixes #165892 Pull Request resolved: #166457 Approved by: https://github.com/coconutruben (cherry picked from commit c2e3cc7)
PaulZhang12
added a commit
that referenced
this pull request
Nov 6, 2025
…plate heuristics (#166457) Fixes #165892 Pull Request resolved: #166457 Approved by: https://github.com/coconutruben (cherry picked from commit c2e3cc7)
atalman
pushed a commit
that referenced
this pull request
Nov 7, 2025
#166922) [Inductor] No longer throw error in bmm out_dtype lowering due to template heuristics (#166457) Fixes #165892 Pull Request resolved: #166457 Approved by: https://github.com/coconutruben (cherry picked from commit c2e3cc7) Co-authored-by: PaulZhang12 <[email protected]>
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #165892
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben