Skip to content

Refactor: extract OperatorArgsKwargsView from parseIValuesToPyArgsKwargs#166368

Closed
swolchok wants to merge 11 commits intogh/swolchok/860/basefrom
gh/swolchok/860/head
Closed

Refactor: extract OperatorArgsKwargsView from parseIValuesToPyArgsKwargs#166368
swolchok wants to merge 11 commits intogh/swolchok/860/basefrom
gh/swolchok/860/head

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Oct 28, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Intended to make it easier to reuse this logic for processing operator arguments as IValues in following PR(s).

Testing: python test/test_python_dispatch.py (broke during development, seems to work now)

@swolchok
Refactor: extract OperatorArgsKwargsView from parseIValuesToPyArgsKwargs
1cf593a 
Intended to make it easier to reuse this logic for processing operator arguments as IValues in following PR(s).

Testing: python test/test_python_dispatch.py (broke during development, seems to work now)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166368

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit b254708 with merge base 84776e1 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Oct 7, 2025
Closed
Closed
Closed
Closed
Closed
Closed
@swolchok
fix bottom-of-stack PR on "Refactor: extract OperatorArgsKwargsView f…
ef164e8 
…rom parseIValuesToPyArgsKwargs"

Intended to make it easier to reuse this logic for processing operator arguments as IValues in following PR(s).

Testing: python test/test_python_dispatch.py (broke during development, seems to work now)

[ghstack-poisoned]
@swolchok swolchok mentioned this pull request Oct 28, 2025
Closed
@swolchok swolchok added the topic: not user facing topic category label Oct 28, 2025
@swolchok
Update on "Refactor: extract OperatorArgsKwargsView from parseIValues…
6151abd 
…ToPyArgsKwargs"

Intended to make it easier to reuse this logic for processing operator arguments as IValues in following PR(s).

Testing: python test/test_python_dispatch.py (broke during development, seems to work now)

[ghstack-poisoned]
@swolchok
partially fix pickling, but tests are still broken on "Refactor: extr…
fa03af6 
…act OperatorArgsKwargsView from parseIValuesToPyArgsKwargs"

Intended to make it easier to reuse this logic for processing operator arguments as IValues in following PR(s).

Testing: python test/test_python_dispatch.py (broke during development, seems to work now)

[ghstack-poisoned]
@swolchok swolchok requested a review from ezyang October 31, 2025 00:06
@swolchok
Copy link
Contributor Author

swolchok commented Oct 31, 2025

noting for reviewers that CI is currently green

@swolchok
rebase, significant fixes to #166370 and following PR on "Refactor: e…
24b67e2 
…xtract OperatorArgsKwargsView from parseIValuesToPyArgsKwargs"

Intended to make it easier to reuse this logic for processing operator arguments as IValues in following PR(s).

Testing: python test/test_python_dispatch.py (broke during development, seems to work now)

[ghstack-poisoned]
@swolchok
Update on "Refactor: extract OperatorArgsKwargsView from parseIValues…
08c6334 
…ToPyArgsKwargs"

Intended to make it easier to reuse this logic for processing operator arguments as IValues in following PR(s).

Testing: python test/test_python_dispatch.py (broke during development, seems to work now)

[ghstack-poisoned]
@swolchok
reproduce dispatch key setup from python fallback in dtensor fallback…
096d96f 
…. fix our "upcall" from Python to DTensor dispatch key to be an explicit redispatch so that the preceding fix doesn't break it. on "Refactor: extract OperatorArgsKwargsView from parseIValuesToPyArgsKwargs"

Intended to make it easier to reuse this logic for processing operator arguments as IValues in following PR(s).

Testing: python test/test_python_dispatch.py (broke during development, seems to work now)

[ghstack-poisoned]
@swolchok
fixed dependency on "Refactor: extract OperatorArgsKwargsView from pa…
a33a3e4 
…rseIValuesToPyArgsKwargs"

Intended to make it easier to reuse this logic for processing operator arguments as IValues in following PR(s).

Testing: python test/test_python_dispatch.py (broke during development, seems to work now)

[ghstack-poisoned]
@swolchok
respect monkey-patching of custom_op_handlers on "Refactor: extract O…
953f369 
…peratorArgsKwargsView from parseIValuesToPyArgsKwargs"

Intended to make it easier to reuse this logic for processing operator arguments as IValues in following PR(s).

Testing: python test/test_python_dispatch.py (broke during development, seems to work now)

[ghstack-poisoned]
@swolchok
fix dependency on "Refactor: extract OperatorArgsKwargsView from pars…
7b11668 
…eIValuesToPyArgsKwargs"

Intended to make it easier to reuse this logic for processing operator arguments as IValues in following PR(s).

Testing: python test/test_python_dispatch.py (broke during development, seems to work now)

[ghstack-poisoned]
@swolchok
Update on "Refactor: extract OperatorArgsKwargsView from parseIValues…
b254708 
…ToPyArgsKwargs"

Intended to make it easier to reuse this logic for processing operator arguments as IValues in following PR(s).

Testing: python test/test_python_dispatch.py (broke during development, seems to work now)

[ghstack-poisoned]
@swolchok swolchok mentioned this pull request Nov 1, 2025
Closed
@swolchok swolchok requested review from XilunWu and wconstab November 3, 2025 23:28
albanD
albanD approved these changes Nov 4, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit on the comment.
But if CI Is happy, I'm happy!

torch/csrc/autograd/python_variable.cpp
// ^- kwarg_only_start
// ^- positional_default_start
// ^- 0
int64_t positional_default_start_;
Copy link
Collaborator

@albanD albanD Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in the middle of the existing comment?

Copy link
Contributor Author

@swolchok swolchok Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally broke it up into two comments: one comment explaining the member variables of OperatorArgsKwargsView and another one explaining what's going on in the constructor.

@swolchok swolchok mentioned this pull request Nov 5, 2025
Closed
@swolchok
Copy link
Contributor Author

swolchok commented Nov 6, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 6, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 6, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Khanaksahu pushed a commit to Khanaksahu/pytorch that referenced this pull request Nov 17, 2025
@swolchok
Refactor: extract OperatorArgsKwargsView from parseIValuesToPyArgsKwargs
ad8921b 
Intended to make it easier to reuse this logic for processing operator arguments as IValues in following PR(s).

Testing: python test/test_python_dispatch.py (broke during development, seems to work now)

ghstack-source-id: 08381e1
Pull Request resolved: pytorch/pytorch#166368
Khanaksahu pushed a commit to Khanaksahu/pytorch that referenced this pull request Nov 17, 2025
@swolchok
Refactor: extract OperatorArgsKwargsView from parseIValuesToPyArgsKwargs
202f4e4 
Intended to make it easier to reuse this logic for processing operator arguments as IValues in following PR(s).

Testing: python test/test_python_dispatch.py (broke during development, seems to work now)

ghstack-source-id: 45a3f63
Pull Request resolved: pytorch/pytorch#166368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@soulitzer soulitzer Awaiting requested review from soulitzer

@ezyang ezyang Awaiting requested review from ezyang

@wconstab wconstab Awaiting requested review from wconstab

@XilunWu XilunWu Awaiting requested review from XilunWu

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok @pytorchmergebot @albanD