Reverts #163712 and forces allgather/scatter inputs/outputs to be contiguous #166181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166181
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit dd38eb9 with merge base 32ac38f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ci-no-td
kwen2501
approved these changes
Oct 24, 2025
…g results (#166181) Summary: Per title cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci Reviewed By: kwen2501 Differential Revision: D85457960 Pulled By: ngimel
facebook-github-bot
force-pushed
the
ngimel/discont_allgather
branch
from
0715c3e to
dd38eb9
Compare
ngimel
changed the title
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Author
|
@pytorchbot cherry-pick --onto release/2.9 --fixes "crash with deterministic scatter_add implementation" -c regression |
pytorchbot
pushed a commit
that referenced
this pull request
Nov 1, 2025
…tiguous (#166181) Per title Pull Request resolved: #166181 Approved by: https://github.com/kwen2501 (cherry picked from commit 2efcf3c)
Collaborator
Cherry picking #166181The cherry pick PR is at #166779 and it is linked with issue crash with deterministic scatter_add implementation. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
atalman
pushed a commit
that referenced
this pull request
Nov 4, 2025
…tiguous (#166779) Reverts #163712 and forces allgather/scatter inputs/outputs to be contiguous (#166181) Per title Pull Request resolved: #166181 Approved by: https://github.com/kwen2501 (cherry picked from commit 2efcf3c) Co-authored-by: Natalia Gimelshein <[email protected]>
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per title
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci