[dynamo] fix keyerror in resume_execution (again) #166040
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166040
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 1 PendingAs of commit afa8775 with merge base ad4dc52 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
The error I attempted to fix in #162318 was still appearing internally. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
williamwen42
commented
Oct 27, 2025
| # The original code and resume code should have matching suffixes. | ||
| # Match the post-prefix block target offsets of the current resume code | ||
| # and the original code. | ||
| orig_targets = reversed( |
Member
Author
There was a problem hiding this comment.
The real fix was to add a bunch of reversed calls
Lucaskabela
approved these changes
Oct 27, 2025
Contributor
Lucaskabela
left a comment
Lucaskabela
left a comment
There was a problem hiding this comment.
Thanks for continuing to drive to fix this key error - hopefully the additional unit test catch everything and close our gap of internal vs OSS here
Fixes #166176 The error I attempted to fix in #162318 was still appearing internally. Surprised that this wasn't caught anywhere 😰 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
Contributor
|
Thanks for fixing this error and unblocking! |
Member
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Contributor
|
@pytorchbot cherry-pick --onto release/2.9 --fixes "error in new nested graphbreak feature (#166033)" -c fixnewfeature |
Collaborator
Cherry picking #166040Command Details for Dev Infra teamRaised by workflow job |
Lucaskabela
pushed a commit
that referenced
this pull request
Nov 4, 2025
Fixes #166176 The error I attempted to fix in #162318 was still appearing internally. Surprised that this wasn't caught anywhere 😰 Pull Request resolved: #166040 Approved by: https://github.com/Lucaskabela ghstack dependencies: #166036 (cherry picked from commit 32fe4f6)
Lucaskabela
pushed a commit
that referenced
this pull request
Nov 4, 2025
Fixes #166176 The error I attempted to fix in #162318 was still appearing internally. Surprised that this wasn't caught anywhere 😰 Pull Request resolved: #166040 Approved by: https://github.com/Lucaskabela ghstack dependencies: #166036 (cherry picked from commit 32fe4f6)
Lucaskabela
pushed a commit
that referenced
this pull request
Nov 4, 2025
Fixes #166176 The error I attempted to fix in #162318 was still appearing internally. Surprised that this wasn't caught anywhere 😰 Pull Request resolved: #166040 Approved by: https://github.com/Lucaskabela ghstack dependencies: #166036 (cherry picked from commit 32fe4f6)
Lucaskabela
pushed a commit
that referenced
this pull request
Nov 4, 2025
Fixes #166176 The error I attempted to fix in #162318 was still appearing internally. Surprised that this wasn't caught anywhere 😰 Pull Request resolved: #166040 Approved by: https://github.com/Lucaskabela ghstack dependencies: #166036 (cherry picked from commit 32fe4f6)
Lucaskabela
pushed a commit
that referenced
this pull request
Nov 4, 2025
Fixes #166176 The error I attempted to fix in #162318 was still appearing internally. Surprised that this wasn't caught anywhere 😰 Pull Request resolved: #166040 Approved by: https://github.com/Lucaskabela ghstack dependencies: #166036 (cherry picked from commit 32fe4f6)
atalman
pushed a commit
that referenced
this pull request
Nov 5, 2025
* [dynamo] fix store attr graph break in with block (#166036) Fixes #166033 Differential Revision: [D85198055](https://our.internmc.facebook.com/intern/diff/D85198055) Pull Request resolved: #166036 Approved by: https://github.com/Lucaskabela (cherry picked from commit ebb2b2e) * [dynamo] fix keyerror in resume_execution (again) (#166040) Fixes #166176 The error I attempted to fix in #162318 was still appearing internally. Surprised that this wasn't caught anywhere 😰 Pull Request resolved: #166040 Approved by: https://github.com/Lucaskabela ghstack dependencies: #166036 (cherry picked from commit 32fe4f6) * fix self.current_instruction -> cur_tx.current_instruction --------- Co-authored-by: William Wen <[email protected]>
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #166176
The error I attempted to fix in #162318 was still appearing internally.
Surprised that this wasn't caught anywhere 😰
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela